Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7aeab611c9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
9427868 to
c595131
Compare
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c595131d7d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
|
/ok to test 1b3a907 |
|
/ok to test 1b3a907 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Validates the standard-cluster E2E suite on Kubernetes 1.34 and 1.35 using pinned K3s images, and documents the tested versions.
The compatibility jobs run all E2E test families supported by the default cluster setup. Scale, AutoMNNVL, startup-ordering, and upgrade tests continue to use their existing dedicated CI targets because they require different cluster lifecycles or configuration.
Kubernetes 1.33 is not included because Dynamic Resource Allocation is disabled by default there and only beta resource APIs are served. Enabling the feature gate does not add
resource.k8s.io/v1, which Grove uses for ResourceClaims and ResourceClaimTemplates; that API is available starting with Kubernetes 1.34.For details, see the Kubernetes 1.33 Dynamic Resource Allocation documentation.
Kubernetes 1.36 coverage is planned next, restoring a three-version compatibility matrix. The version-keyed configuration also remains extensible for the future coverage tracked in #605. Finding this API boundary demonstrates the value of running the compatibility suite against pinned Kubernetes release lines.
Which issue(s) this PR fixes:
Related to #806
Related to #605
Special notes for your reviewer:
Validated with
make validate,make check, workflow YAML parsing, Make target expansion, explicit K3s image overrides, unsupported-version handling, andgit diff --check. The compatibility E2E matrix was not run locally due to its runtime.Does this PR introduce an API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: