Skip to content

ci: test Kubernetes 1.34-1.35 - #820

Open
yankay wants to merge 3 commits into
ai-dynamo:mainfrom
yankay:feat/kubernetes-compatibility-matrix
Open

yankay wants to merge 3 commits into
ai-dynamo:mainfrom
yankay:feat/kubernetes-compatibility-matrix

Conversation

@yankay

@yankay yankay commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Validates the standard-cluster E2E suite on Kubernetes 1.34 and 1.35 using pinned K3s images, and documents the tested versions.

The compatibility jobs run all E2E test families supported by the default cluster setup. Scale, AutoMNNVL, startup-ordering, and upgrade tests continue to use their existing dedicated CI targets because they require different cluster lifecycles or configuration.

Kubernetes 1.33 is not included because Dynamic Resource Allocation is disabled by default there and only beta resource APIs are served. Enabling the feature gate does not add resource.k8s.io/v1, which Grove uses for ResourceClaims and ResourceClaimTemplates; that API is available starting with Kubernetes 1.34.

For details, see the Kubernetes 1.33 Dynamic Resource Allocation documentation.

Kubernetes 1.36 coverage is planned next, restoring a three-version compatibility matrix. The version-keyed configuration also remains extensible for the future coverage tracked in #605. Finding this API boundary demonstrates the value of running the compatibility suite against pinned Kubernetes release lines.

Which issue(s) this PR fixes:

Related to #806
Related to #605

Special notes for your reviewer:

Validated with make validate, make check, workflow YAML parsing, Make target expansion, explicit K3s image overrides, unsupported-version handling, and git diff --check. The compatibility E2E matrix was not run locally due to its runtime.

Does this PR introduce an API change?

NONE

Additional documentation e.g., enhancement proposals, usage docs, etc.:

README.md
docs/installation.md
docs/quickstart.md

@copy-pr-bot

copy-pr-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T09:32:17.107009Z c595131 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7aeab611c9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread operator/Makefile Outdated
@yankay
yankay marked this pull request as draft September 10, 2026 08:45
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@yankay
yankay force-pushed the feat/kubernetes-compatibility-matrix branch from 9427868 to c595131 Compare September 10, 2026 09:04
@yankay yankay changed the title ci: add Kubernetes compatibility matrix ci: test Kubernetes 1.33-1.35 Sep 10, 2026
@yankay
yankay marked this pull request as ready for review September 10, 2026 09:27
Signed-off-by: Kay Yan <kay.yan@daocloud.io>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c595131d7d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread operator/Makefile Outdated
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@yankay yankay changed the title ci: test Kubernetes 1.33-1.35 ci: test Kubernetes 1.34-1.35 Sep 10, 2026
@yankay

yankay commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 1b3a907

@sanjaychatterjee

Copy link
Copy Markdown
Collaborator

/ok to test 1b3a907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants