fix(protocols): accept null stream option flags - #239
Merged
Merged
Conversation
Signed-off-by: furionw <qiwa@nvidia.com>
luckyq
approved these changes
Sep 17, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include_usageandcontinuous_usage_statsasfalse.boolfields and their serialized boolean wire shape.This moves the compatibility behavior into the shared protocol type used by chat and text completion requests. It is the durable protocol-side fix for the stream-options portion of ai-dynamo/dynamo#14847; after Dynamo consumes a release containing this change, its frontend-only nullable stream-options wrapper can be removed.
Compatibility
This is a deserialization-only relaxation. Existing Rust constructors remain source-compatible, JSON and MessagePack serialization remain boolean-valued, and mixed-version request-plane traffic retains the existing wire shape.
Validation
cargo fmt --all -- --checkcargo test -p dynamo-protocols --all-targets --lockedcargo test -p dynamo-protocols --doc --lockedcargo clippy -p dynamo-protocols --all-targets --all-features --locked -- -D warningscargo check --workspace --all-targets --lockedcargo test --workspace --all-targets --locked --exclude dynamo-conformance-fixtures-v2cargo clippy --workspace --all-targets --all-features --locked -- -D warningsThe unfiltered workspace test run reached the conformance package and stopped because the local macOS environment does not provide
flock; the same workspace run excluding that environment-specific fixture package passed.