fix(sglang): inherit reasoning_parser and tool_call_parser in LoRA registration - #14863
Closed
julianStreibel wants to merge 1 commit into
Closed
julianStreibel wants to merge 1 commit into
julianStreibel wants to merge 1 commit into
Conversation
…gistration The SGLang backend's load_lora handler publishes adapter ModelDeploymentCards without runtime_config, so the frontend does not apply reasoning or tool-call parsing for adapter-name requests. Apply the same fix as PR ai-dynamo#7559 (vLLM backend): call _get_runtime_config() to build a ModelRuntimeConfig with the worker's --dyn-reasoning-parser and --dyn-tool-call-parser and pass it to register_llm(). This is a backport of the fix already on main (commit 8957ec3, PR ai-dynamo#12092) to the release/1.4.2 branch. Fixes ai-dynamo#14862 Signed-off-by: Julian Streibel <julian@construct-labs.com>
julianStreibel
deployed
to
external_collaborator
September 15, 2026 17:11 — with
GitHub Actions
Active
julianStreibel
deployed
to
external_collaborator
September 15, 2026 17:11 — with
GitHub Actions
Active
Contributor
|
👋 Hi julianStreibel! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
Contributor
|
Hi @julianStreibel, thanks for raising this. The 1.4.2 release is already shipped, so we won't backport new changes to it. However, the v1.5.0 release should be coming out very soon, which contains this fix - the recommended path forward is to upgrade to v1.5.0 to pickup this fix, or install a nightly wheel or build from source for custom builds as needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of the LoRA runtime_config fix (already on
mainvia commit 8957ec3 / PR #12092) to therelease/1.4.2branch.Problem
The SGLang backend's
load_lorahandler publishes adapterModelDeploymentCards withoutruntime_config. The adapter card has noreasoning_parserortool_call_parser, so the Rust frontend postprocessor does not:<think>...</think>blocks intoreasoning_content<tool_call>blocks into structuredtool_callsfor adapter-name requests. Base model requests work correctly because the base worker's card carries the parsers.
Fix
Call
_get_runtime_config()beforeregister_llm()in theload_loramethod to construct aModelRuntimeConfigwith the worker's--dyn-reasoning-parserand--dyn-tool-call-parsersettings. This mirrors:mainin PR fix(frontend): reject over-context requests before streaming #12092Changes
components/src/dynamo/sglang/request_handlers/handler_base.py:_get_runtime_configfromdynamo.sglang.registerruntime_configfrom the engine and dynamo argsruntime_config=runtime_configtoregister_llm()Fixes #14862