Skip to content

fix(vllm/omni): pass response_format into video EngineInputs (#14667) #14844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmccorm4 merged 2 commits into from
Sep 18, 2026
+22 −0
Merged

fix(vllm/omni): pass response_format into video EngineInputs (#14667) #14844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e757801
fix(vllm): pass response_format through omni video EngineInputs
Prudctual Sep 15, 2026
4ffdc68
test(vllm): drop image response_format forwarding test
Prudctual Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/src/dynamo/vllm/omni/omni_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,5 +810,6 @@ def _engine_inputs_from_video(
sampling_params_list=sampling_params_list,
request_type=RequestType.VIDEO_GENERATION,
fps=fps,
response_format=req.response_format,
lora_request=lora_request,
)
21 changes: 21 additions & 0 deletions components/src/dynamo/vllm/tests/omni/test_omni_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,27 @@ async def test_video_generation(self):
assert inputs.request_type == RequestType.VIDEO_GENERATION
assert inputs.prompt["prompt"] == "a drone"
assert inputs.fps > 0
assert inputs.response_format is None

@pytest.mark.parametrize("response_format", ["b64_json", "url"])
@pytest.mark.asyncio
async def test_video_and_i2v_forward_response_format(self, response_format):
"""T2V and I2V share _engine_inputs_from_video; b64_json must not be dropped."""
handler = _make_handler()
req = NvCreateVideoRequest(
prompt="a drone",
model="test-model",
size="832x480",
response_format=response_format,
)
t2v = await handler.build_engine_inputs(req, RequestType.VIDEO_GENERATION)
assert t2v.response_format == response_format

img = Image.new("RGB", (64, 64), color="red")
i2v = await handler.build_engine_inputs(
req, RequestType.VIDEO_GENERATION, image=img
)
assert i2v.response_format == response_format

@pytest.mark.asyncio
async def test_audio_generation_delegates_toaudio(self):
Expand Down
Loading