fix: tolerate benign trailing prose after final tool request - #1832
Open
sendralt wants to merge 1 commit into
Open
fix: tolerate benign trailing prose after final tool request#1832sendralt wants to merge 1 commit into
sendralt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an agent emits a fully valid tool-request JSON followed by stray non-JSON text, the strict equality gate in extract_tool_request (root != content) rejects the whole message as misformat, the tool never executes, and the run degrades into repair loops.
A naive relaxation (accepting any prefix) is unsafe: streaming early-stop and repair routing rely on strict rejection of trailing text, e.g. tests/test_tool_request_normalization.py asserts trailing-text rejection and stream snapshots must not stop early while a second tool call may still be streaming.
Solution
Boundary-scoped leniency:
Testing