fix: accept complete fenced JSON tool requests - #1829
Open
er-s-an wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json-tagged and untagged fences while keeping the execution boundary fail-closed for prose, malformed fences, multiple fences, and non-tool JSONFixes #1811
Why
is_misformatted_tool_request()already recognizes fenced tool JSON, butextract_tool_request()only accepted bare JSON. A correct tool call wrapped by a chat model in one Markdown fence therefore entered the misformat circuit breaker instead of executing.The parser remains intentionally strict: it only unwraps a fence when
fullmatch()covers the complete trimmed reply, then applies the existing complete-root and tool-envelope checks.Verification
python -m pytest -q tests/test_tool_request_normalization.py— 27 passedpython -m compileall -q helpers/extract_tools.pygit diff --check origin/main...HEAD