Repository navigation
fix(worktree): focus the branch field when the create form swaps in over a filtered list - #1203
Open
dingxiaobo wants to merge 1 commit into
Open
dingxiaobo wants to merge 1 commit into
dingxiaobo wants to merge 1 commit into
Conversation
…ver a filtered list Eight or more choices show a filter field above the menu's list, marked to take focus when the menu opens. The "New worktree…" form's branch input is marked too, but it comes after the filter in the page, so the focus that follows a body swap landed on the filter instead of the branch name. A swap now hands the autofocus claim to the new body's own marked control; the opening keeps the old target, and a swap back to the list falls back to it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eight or more choices show a filter field above the menu's list, marked to take focus when the menu opens. The "New worktree…" form's branch input is marked too, but it comes after the filter in the page, so the focus that follows a body swap landed on the filter instead of the branch name. A swap now hands the autofocus claim to the new body's own marked control; the opening keeps the old target, and a swap back to the list falls back to it.