Skip to content

fix(qiankun): report standalone startup failures - #137

Merged
xusd320 merged 1 commit into
mainfrom
xusd320/fix-qiankun-standalone-errors
Sep 18, 2026
Merged

xusd320 merged 1 commit into
mainfrom
xusd320/fix-qiankun-standalone-errors

Conversation

@xusd320

@xusd320 xusd320 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Changes

  • Catch the generated standalone startup rejection with globalThis.reportError, falling back to an asynchronous throw when unavailable.
  • Add 11 regression cases covering generated entry loading, mount/start failures, fallback reporting, successful startup, host error ownership, and lifecycle queue recovery.
  • Update the English and Chinese qiankun documentation.

Validation

  • Confirmed four generated-entry regression cases fail before the fix.
  • npm --workspace @evjs/plugin-qiankun test — 74 tests passed.
  • npm run check-types
  • npm run lint
  • npm test
  • npm --workspace evjs-docs run build — English and Chinese builds passed.
  • git diff --check

Risk / rollout

  • Low risk: the change is limited to automatic standalone startup reporting. Lifecycle rejection, queue recovery, and host-controlled mounting retain their existing behavior.
  • Applications must rebuild to receive the updated generated entry.

Reviewer notes

  • The regression tests execute the generated wrapper with the real lifecycle runtime and check original error identity, fallback reporting, and host behavior.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-18T03:19:28.645850Z 12b1146 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@xusd320
xusd320 merged commit 3c7f53b into main Sep 18, 2026
1 check passed
@xusd320
xusd320 deleted the xusd320/fix-qiankun-standalone-errors branch September 18, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(qiankun): standalone startup failures leave a blank page without reporting errors

1 participant