Remove direction bars and fix sunset arrival guidance - #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sunset guidance now opens when estimated arrival reaches 30 minutes before sunset or later. A flight can show its sunset margin while sunset is still hours away. Without an available arrival estimate, the existing current-time window applies, and guidance still expires one hour after sunset. Replay diagnostics use the same display gate as live flight.
Remove the green screen-edge direction bars and their unused acquisition logic. The existing direction instrument remains. Three-digit sunset countdowns fit beside duration by widening the right instrument column, with unchanged type size and row height.
Replace the simplified sunrise equation with local Meeus/NOAA solar-position and equation-of-time calculations, iterated at each rise/set event. Fourteen independent USNO date/location fixtures now require sunrise and sunset to round to the published minute; the former sunset calculation differed by up to 83 seconds from those published values, versus 26 seconds with the new calculation. Absolute clock labels also round to the nearest minute.
The FAA directs pilots to USNO calculated tables. These calculations use the standard upper-limb horizon and refraction; terrain and pilot altitude are not inputs. Reference queries are recorded with the fixtures and are never called by the app.
Validation: