"Hook rules were not satisfied" should be 401, not 200

[boyska]

As per the title, I would expect that a POST to trigginering a webhook with wrong parameters should return in a 4xx status code, not 200.

This would make it much easier to verify if the hook has been correctly submitted.

[moorereason]

That's not how webhook was designed. You could receive many types of hooks at a given endpoint and only want to trigger under specific circumstances. For example, webhooks from commits to a git repository should only trigger if the commit was to a specific branch.

It may be possible to add a "fail-when-not-matched" option to achieve what you want, though.

[boyska]

I see your point! it's a bit unfortunate there is no distinction between rules which are authentication and other business logic, but oh well.
A fail-when-not-matched option would be ideal indeed.

Another approach which would partly solve my concern could be to have a more informative response. Sure, I can check for "Hook rules were not satisfied", but it seems fragile: can I rely on this string never changing in future versions of webhook? Ideally, I would get a JSON result like this:

{ "success": false }

[moorereason]

I've been using webhook for years and never needed to do what you're doing, so it seems like I've forgotten that webhook already does what you want. Example:

webhook/test/hooks.json.tmpl

Line 8 in 2e4aea4

"trigger-rule-mismatch-http-response-code": 400,