75 major refactoring - #77
Open
mauro-milella wants to merge 16 commits into
Open
mauro-milella wants to merge 16 commits into
mauro-milella wants to merge 16 commits into
Conversation
Loss, ClassificationLoss, RegressionLoss, default_loss_function, istoploss
Integrating local changes into MDT refactoring
mauro-milella
requested review from
PasoStudio73,
Perro2110,
alberto-paparella,
edo-007,
eduardstan,
ferdiu,
giopaglia and
lele7x
October 12, 2025 19:13
…dset, anchor, AbstractDecision, AbstractNode, AbstractDecisionLeaf, AbstractDecisionInternal, DTNode
…sinsubtree, isleftchild, isrightchild, isinleftsubtree, isinrightsubtree
ferdiu
requested changes
Oct 13, 2025
ferdiu
left a comment
ferdiu
left a comment
Member
There was a problem hiding this comment.
Every change seems reasonable but the errors in tests requires more in-depth investigation.
Member
Author
|
Thank you fede, yes my idea is to continue exploring the package while adjusting things (and tests) along the way. There's still a lot to do |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #75.