This repository was archived by the owner on Jul 28, 2021. It is now read-only.
404 Page for missing pages - #43
Open
revanth-reddy wants to merge 4 commits into
Open
revanth-reddy wants to merge 4 commits into
revanth-reddy wants to merge 4 commits into
Conversation
Author
|
404 page is rendered only in production, for that DEBUG has to be False To visualise it in local development environment comment line 6 and add the following two lines in src/appstore/settings/development.py : DEBUG = False |
| ] | ||
|
|
||
| #importing custom 404 page handler from "appstore" app views.py | ||
| from appstore.views import handler404 |
There was a problem hiding this comment.
Why do we need this here?
Author
There was a problem hiding this comment.
Yes, it's not mandatory to import handler404 from appstore.views as we already imported views :)
rewriting it to
handler404 = views.handler404
would also do the job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we visit an unexisting link then Django displays a default ERROR 404 page.
This PR is for a custom 404 error handler.
in reference to issue #41