Repository navigation
Fix negated SmartMultiInput conditions, launchpad sample links, AMC feed markup and a stale AI settings strip - #96
Merged
Conversation
Z2UI5_CL_SMPS_APP_013 left the result strip of an earlier connection test or of a failed save on screen after a successful save, so a red "save failed" or a test answer for the old configuration stood next to the "Settings saved" toast. A successful save now clears it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
Z2UI5_CL_SMPS_APP_319 translated every operation it did not list into an EQ on the first value, so NotEQ, NotBT, NotStartsWith, NotEmpty and the other negated conditions selected exactly the rows the user had asked to leave out. A Not* operation is now its positive twin with the sign turned round (NotContains included, which no longer ignores the exclude flag), Initial is read like Empty, and an operation the sample still does not know is left out of the range and named in the hint instead of guessed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
Both copies of url_param_get_tab (the overview app and z2ui5_cl_smps_context) kept only what followed sap-startup-params, so in the Fiori launchpad the sample links lost sap-client and sap-language and opened in the default client. They also decoded %26 and %3D in every value and cut at a `?` inside a value, dropping every parameter before it. Both now follow the fixed copy in abap2UI5's z2ui5_cl_ui5_util_context: cut at the first `?`, decode only the packed startup parameters, and keep what stands before them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
Z2UI5_CL_SMPS_APP_489 put the text that arrives over the channel straight into a FeedListItem, which renders its text as FormattedText - so markup one user typed (a link, bold, a list) reached every other open session as markup. The text is now HTML-escaped on the way into the feed, the way Z2UI5_CL_SMPS_APP_014 already does it for its chat. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
oblomov-dev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One commit per fix:
EQon the first value. As a resultNotEQ,NotBT,NotStartsWith,NotEmptyand the other negated conditions selected exactly the rows the user had asked to leave out, andNotContainsignored the exclude flag. ANot*operation is now mapped as its positive twin with the sign turned round, andInitialis read likeEmpty. An operation the sample still does not know is left out of the range and counted in the hint instead of being guessed.url_param_get_tab: both copies kept only what followedsap-startup-params. Inside the Fiori launchpad, the sample links therefore lostsap-client/sap-languageand opened in the default client. Both now follow the fixed copy in abap2UI5'sz2ui5_cl_ui5_util_context: cut at the first?, decode only the packed startup parameters, and keep what stands before them.Checked locally:
npm run checkis green. abaplint is clean on the generated package branches 01-odata, 02-smart-controls, 03-rap, 07-amc-apc and 10-ai-llm, each at its release floor.🤖 Generated with Claude Code
https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt