Repository navigation
Enable 143 more abaplint rules - #14
Merged
Merged
Conversation
Adopt every rule of abap2UI5's own abaplint.jsonc that reports nothing on the examples' ABAP, with abap2UI5's settings, as a block of its own. Among them: check_subrc, uncaught_exception, sql_escape_host_variables, select_add_order_by, strict_sql, unused_variables, cyclic_oo, dangerous_statement, empty_structure, check_ddic. downport and parser_702_chaining stay out: the examples need 7.55 and are never downported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
Member
Author
|
The red e2e jobs are not caused by this PR. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
abaplint.jsoncgains a block of 143 rules. They are every rule from abap2UI5's ownabaplint.jsoncthat has no finding on the examples' ABAP (fiori-elements-v2/abap/), and they keep abap2UI5's settings. The 14 existing rules are unchanged.Among the added rules:
check_subrc,uncaught_exception,sql_escape_host_variables,select_add_order_by,strict_sql,modify_only_own_db_tables,unused_variables,unused_methods,cyclic_oo,dangerous_statement,empty_structure,check_ddic,implement_methods,cds_field_orderandcds_association_name. The full list is in the diff.Why
The app class is "built like any abap2UI5 app" (AGENTS.md), yet abaplint only checked its syntax and file hygiene. With these rules it is also held to the correctness, SQL and style rules the framework holds itself to.
Left out:
downportandparser_702_chaining: they have no findings, but the examples need 7.55 (view entities, RAP with OData V2) and are never downported.allowed_object_types(4 findings): it would need the DDLX, SRVD and SRVB types that abap2UI5's list does not have, and restricting object types is a design decision.object_namingandcds_naming: abap2UI5's naming patterns.No code changes.
Checked
npm run abaplintreports 0 issues, andnpm run lintandnpm run format:checkpass. Only the config changes, so the build and the Playwright run are not affected.🤖 Generated with Claude Code
https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
Generated by Claude Code