Repository navigation
Let the late-component test follow the frontend under its second name - #13
Merged
Merged
Conversation
The control of embed-control's main creates the frontend under the name the bundle's z2ui5/embed module gives (componentName, z2ui5.embed.frontend on abap2UI5 main) - the test only intercepted a Component.create for "z2ui5", never saw the start and ran into its timeout, which turned embed-control's CI red on main. It intercepts both names now, so it passes with the published control and with the one of embed-control's main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
test/e2e/freestyle.spec.mjs, "a component still being created is destroyed": the test interceptsComponent.createfor the frontend under either name -z2ui5, orz2ui5.embed.frontend, the second name the bundle of abap2UI5 main gives it (componentNameofz2ui5/embed).Why
The control of embed-control's
main(abap2UI5/embed-control#25) creates the frontend undercomponentNamewhenever the bundle names one. The test only intercepted a create for"z2ui5", never saw the start, and ran into its 60 s timeout - four failures (ui5-1.136andui5-1.71, both variants) that turned thesamples (abap2UI5 main)job of embed-control's CI red onmainsince #25 (run 38077811145) and on every embed-control pull request. With the published control 0.1.1 the name is stillz2ui5, so the test passes with both, as AGENTS.md ("Tested from two sides") asks.The component's metadata name stays
z2ui5.Componentunder both names (the bundle registers the sameComponent.jstwice), so the rest of the test is unchanged.Independent of the dependency update in #12; either can be merged first.
Note: the
e2ejobs of this repository are red onmainindependently of this change - the freestyle tests forrestart(), the invisible control, endpoint spellings, the failed-load fallback and the params handling need the unreleased control (embed-control's "Unreleased" changelog section) and fail with the published 0.1.1. They turn green with the release of the control and its bump here.Checked
npm run lint,npm run format:check; with abap2UI5 main on:3000and the control of embed-control'smaininnode_modules/@abap2ui5/embed-control:npx playwright test --project ui5-1.136 --project ui5-1.71 -g "still being created"- 4 passed (all four failed before).🤖 Generated with Claude Code
https://claude.ai/code/session_01Te3BRpRpxNhZAYnrQL6Gdt
Generated by Claude Code