Repository navigation
List sap.ui.codeeditor in every example's UI5 configuration - #10
Merged
Merged
Conversation
ui5 serve serves only the libraries framework.libraries names, and abap2UI5's developer tools (Ctrl+F12 in an embedded app) require sap/ui/codeeditor/CodeEditor - without the library the dev server answers 404 and the tools fail with a script load error. Every ui5.yaml, ui5-local.yaml and ui5-1.71.yaml lists it now, with the reason next to the list; the READMEs say what the list has to carry. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FVEXYcCLJmoHyetpCT57uv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
ui5.yaml,ui5-local.yamlandui5-1.71.yamlof the four examples listssap.ui.codeeditorunderframework.libraries, with the reason as a comment next to the list.freestyle/README.md("Run it") say what the library list has to carry.Why
ui5 serveserves only the librariesframework.librariesnames. abap2UI5's developer tools (Ctrl+F12 in an embedded app) loadsap/ui/codeeditor/CodeEditor, which none of the examples listed - the dev server answered 404 and the tools failed withDeveloperTools.show failed - ModuleError: failed to load 'sap/ui/codeeditor/CodeEditor.js'. Seen while running the freestyle example against a system. A deployed app is not affected, the system has every library.Checked
npm run lint,npm run format:checknpx playwright test --project ui5-1.136 --project ui5-1.71 --project cardagainst@abap2ui5/node-runtime1.146.0, with the control of abap2UI5/embed-control's main innode_modulesas its CI does: 55 passed, 1 skipped. With the published control 0.1.1, 14 tests offreestyle.spec.mjsfail independently of this change (they testrestart(), invisible containers and refused endpoints, which the published version does not have yet).🤖 Generated with Claude Code
https://claude.ai/code/session_01FVEXYcCLJmoHyetpCT57uv
Generated by Claude Code