Repository navigation
view-chain-layout: close the list before the button in the example - #271
Merged
Merged
Conversation
The example chain opened List and items and closed them with ONE end( ), written in the column of List. end( ) ascends one level, so that end( ) closed only items, and the Save button that follows became a child of the List (its default aggregation items) instead of the Page: before <List><items><StandardListItem/></items><Button/></List> after <List><items><StandardListItem/></items></List><Button/> The example now has the second end( ), each in the column of the ele( ) it closes - rule 4 of the same file, which the old example broke while teaching it. The file is shared byte-for-byte between abap2UI5, samples, samples-controls and samples-stack (shared-file-gate in abap2UI5), so the same one-line change goes to all four. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QYMKjK1h4aPzf4w4E7RCZW
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the shared copy of the fix in abap2UI5/abap2UI5. abap2UI5 is the source of
.claude/skills/view-chain-layout/SKILL.md, and itsshared-file-gaterequires this copy to stay byte-identical.The example chain closed
Listanditemswith only oneend( ), so the Save button landed inside the List (<List>…<Button/></List>) instead of on the Page. This change adds the missingend( ), so eachend( )stands in the column of theele( )it closes, as rule 4 says. It is one line and only touches this skill file.🤖 Generated with Claude Code
https://claude.ai/code/session_01QYMKjK1h4aPzf4w4E7RCZW
Generated by Claude Code