Repository navigation
Fix tooling-tests on main after #261: lazy playwright import in e2e-smoke - #262
Merged
Merged
Conversation
tooling-tests runs npm test without npm ci, and the new tests drive
e2e-smoke's argument parse and --list-demo-apps as a subprocess - the
top-level `import { chromium } from 'playwright'` failed there before
either ran (exit 1 instead of 0 / 2). The import moves next to the
browser launch.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017djANPyp3d2DmqGu6Xnca1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up to #261.
tooling-testsis red onmain: two of the new tests fail with exit 1 instead of 0 or 2.e2e-smoke and validate-meta read the demo apps…e2e-smoke: --port is validated…Cause: the workflow runs
npm testwithoutnpm ci. Both tests startscripts/e2e-smoke.mjsas a subprocess, and its top-levelimport { chromium } from 'playwright'fails before the argument parse or--list-demo-appsruns.Fix:
playwrightis now loaded with a dynamic import, right before the browser is launched. The parse and--list-demo-appsno longer need it, and a real smoke run behaves as before.Test plan
node_modulesmoved away,npm testshows exactly these twonot oklinesnpm testpasses 63/63, both without and withnode_modulese2e-smoke --only 578 --port 3105against the built backend: pass, including the interaction🤖 Generated with Claude Code
https://claude.ai/code/session_017djANPyp3d2DmqGu6Xnca1
Generated by Claude Code