Repository navigation
Clarify embed control, build process, and delivery architecture - #91
Merged
Merged
Conversation
…2UI5 README (held byte-identical to abap2UI5's frontend/common/README.md), CONTRIBUTING, AGENTS.md and the deliver comment still described the six trees as committed under build/ in abap2UI5. Nothing is committed there: frontend_check builds into tools/out/ on the pull request and frontend_deploy runs the same build on main, which is where the stamped trees come from. AGENTS.md gets a section on the two kinds of branch: the classic ones carrying a copy of app/webapp, and standard_new / cloud_new carrying one z2ui5.embed.Container that loads the frontend from the backend - with the app in frontend/embed, the control in abap2UI5/embed-control (pinned as @abap2ui5/embed-control), and the deployment identity both kinds share. CONTRIBUTING, the guard message and the pull request template name the same two places. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NMqeR6v28CHcmUTCNMKZjL
github-actions Bot
added a commit
that referenced
this pull request
Oct 12, 2026
…2UI5 (#91) README (held byte-identical to abap2UI5's frontend/common/README.md), CONTRIBUTING, AGENTS.md and the deliver comment still described the six trees as committed under build/ in abap2UI5. Nothing is committed there: frontend_check builds into tools/out/ on the pull request and frontend_deploy runs the same build on main, which is where the stamped trees come from. AGENTS.md gets a section on the two kinds of branch: the classic ones carrying a copy of app/webapp, and standard_new / cloud_new carrying one z2ui5.embed.Container that loads the frontend from the backend - with the app in frontend/embed, the control in abap2UI5/embed-control (pinned as @abap2ui5/embed-control), and the deployment identity both kinds share. CONTRIBUTING, the guard message and the pull request template name the same two places. Claude-Session: https://claude.ai/code/session_01NMqeR6v28CHcmUTCNMKZjL Co-authored-by: Claude <noreply@anthropic.com>
github-actions Bot
added a commit
that referenced
this pull request
Oct 12, 2026
…2UI5 (#91) README (held byte-identical to abap2UI5's frontend/common/README.md), CONTRIBUTING, AGENTS.md and the deliver comment still described the six trees as committed under build/ in abap2UI5. Nothing is committed there: frontend_check builds into tools/out/ on the pull request and frontend_deploy runs the same build on main, which is where the stamped trees come from. AGENTS.md gets a section on the two kinds of branch: the classic ones carrying a copy of app/webapp, and standard_new / cloud_new carrying one z2ui5.embed.Container that loads the frontend from the backend - with the app in frontend/embed, the control in abap2UI5/embed-control (pinned as @abap2ui5/embed-control), and the deployment identity both kinds share. CONTRIBUTING, the guard message and the pull request template name the same two places. Claude-Session: https://claude.ai/code/session_01NMqeR6v28CHcmUTCNMKZjL Co-authored-by: Claude <noreply@anthropic.com>
github-actions Bot
added a commit
that referenced
this pull request
Oct 12, 2026
…2UI5 (#91) README (held byte-identical to abap2UI5's frontend/common/README.md), CONTRIBUTING, AGENTS.md and the deliver comment still described the six trees as committed under build/ in abap2UI5. Nothing is committed there: frontend_check builds into tools/out/ on the pull request and frontend_deploy runs the same build on main, which is where the stamped trees come from. AGENTS.md gets a section on the two kinds of branch: the classic ones carrying a copy of app/webapp, and standard_new / cloud_new carrying one z2ui5.embed.Container that loads the frontend from the backend - with the app in frontend/embed, the control in abap2UI5/embed-control (pinned as @abap2ui5/embed-control), and the deployment identity both kinds share. CONTRIBUTING, the guard message and the pull request template name the same two places. Claude-Session: https://claude.ai/code/session_01NMqeR6v28CHcmUTCNMKZjL Co-authored-by: Claude <noreply@anthropic.com>
github-actions Bot
added a commit
that referenced
this pull request
Oct 12, 2026
…2UI5 (#91) README (held byte-identical to abap2UI5's frontend/common/README.md), CONTRIBUTING, AGENTS.md and the deliver comment still described the six trees as committed under build/ in abap2UI5. Nothing is committed there: frontend_check builds into tools/out/ on the pull request and frontend_deploy runs the same build on main, which is where the stamped trees come from. AGENTS.md gets a section on the two kinds of branch: the classic ones carrying a copy of app/webapp, and standard_new / cloud_new carrying one z2ui5.embed.Container that loads the frontend from the backend - with the app in frontend/embed, the control in abap2UI5/embed-control (pinned as @abap2ui5/embed-control), and the deployment identity both kinds share. CONTRIBUTING, the guard message and the pull request template name the same two places. Claude-Session: https://claude.ai/code/session_01NMqeR6v28CHcmUTCNMKZjL Co-authored-by: Claude <noreply@anthropic.com>
github-actions Bot
added a commit
that referenced
this pull request
Oct 12, 2026
…2UI5 (#91) README (held byte-identical to abap2UI5's frontend/common/README.md), CONTRIBUTING, AGENTS.md and the deliver comment still described the six trees as committed under build/ in abap2UI5. Nothing is committed there: frontend_check builds into tools/out/ on the pull request and frontend_deploy runs the same build on main, which is where the stamped trees come from. AGENTS.md gets a section on the two kinds of branch: the classic ones carrying a copy of app/webapp, and standard_new / cloud_new carrying one z2ui5.embed.Container that loads the frontend from the backend - with the app in frontend/embed, the control in abap2UI5/embed-control (pinned as @abap2ui5/embed-control), and the deployment identity both kinds share. CONTRIBUTING, the guard message and the pull request template name the same two places. Claude-Session: https://claude.ai/code/session_01NMqeR6v28CHcmUTCNMKZjL Co-authored-by: Claude <noreply@anthropic.com>
github-actions Bot
added a commit
that referenced
this pull request
Oct 12, 2026
…2UI5 (#91) README (held byte-identical to abap2UI5's frontend/common/README.md), CONTRIBUTING, AGENTS.md and the deliver comment still described the six trees as committed under build/ in abap2UI5. Nothing is committed there: frontend_check builds into tools/out/ on the pull request and frontend_deploy runs the same build on main, which is where the stamped trees come from. AGENTS.md gets a section on the two kinds of branch: the classic ones carrying a copy of app/webapp, and standard_new / cloud_new carrying one z2ui5.embed.Container that loads the frontend from the backend - with the app in frontend/embed, the control in abap2UI5/embed-control (pinned as @abap2ui5/embed-control), and the deployment identity both kinds share. CONTRIBUTING, the guard message and the pull request template name the same two places. Claude-Session: https://claude.ai/code/session_01NMqeR6v28CHcmUTCNMKZjL Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Documentation updates across AGENTS.md, README.md, CONTRIBUTING.md, and workflow files to clarify:
The embed control separation:
z2ui5.embed.Containeris developed and published separately in abap2UI5/embed-control, not in abap2UI5 or this repository. Added a new "The embed control" section to AGENTS.md explaining the control's source, versioning, and deployment identity.Build process accuracy: Corrected the description of how branches are built. The build happens at deploy time into git-ignored
tools/out/, not into a committedbuild/directory. No delivery trees are committed in abap2UI5 —frontend_checkbuilds on pull requests,frontend_deploybuilds on main and stamps the result.The
_newbranches: Clarified thatcloud_newandstandard_newcarry no copy of the abap2UI5 frontend. Their app is infrontend/embed/and loads the frontend from the backend at runtime via the embed control, eliminating the need to pull frontend updates separately.Routing guidance: Updated pull request template, guard workflow, and CONTRIBUTING.md to direct changes to the correct repositories:
app/webapp/_newbranch app changes → abap2UI5frontend/embed/Why
The previous documentation conflated the build process (suggesting committed
build/trees) with the actual git-ignoredtools/out/build artifacts, and did not clearly explain that the embed control is a separate project with its own repository and npm package. This caused confusion about where changes belong and how the delivery pipeline actually works.Why this belongs in this repository
This is a documentation-only change to this repository's own docs (AGENTS.md, README.md, CONTRIBUTING.md, and workflow comments). These files are maintained here and not generated. No changes to generated content or build logic.
Requesting 'maintenance' label to unlock the guard check.
https://claude.ai/code/session_01NMqeR6v28CHcmUTCNMKZjL