Repository navigation
Conversation
Dynamic schemas represented ROS byte fields as uint8, producing a different type hash despite identical CDR encoding. This made GetTypeDescription reject the canonical ParameterEvent hash advertised by parameterized nodes. Add a distinct Byte schema variant across code generation, runtime loading, type-description conversion, and value handling. Correct the built-in ParameterValue schema and extend existing tests and codegen snapshots. Validation: scripts/check-local.sh passed 605 tests, formatting, builds, examples, and rustdoc links. Clippy fails on a lifecycle recursion-depth diagnostic reproduced on unchanged upstream. Optional Nushell and mdbook checks were unavailable.
0x53A
force-pushed
the
fix/dynamic-byte-type
branch
from
October 6, 2026 22:42
6030d79 to
953a7c3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm trying out the support for
get_type_descriptionand hit a bug wherercl_interfaces/msg/ParameterEventfails with a hash mismatch between the advertised topic and the service’s registered schema.ROS distinguishes
byteanduint8in type descriptions, even though their binary representation is the same. ROS mapsuint8(andchar) to IDLuint8, whilebytemaps to IDLoctet.Checklist
./scripts/check-local.shsuccessfullythere's a pre-existing clippy failure on main
External contributors: Please open as draft initially. See CONTRIBUTING.md.