Repository navigation
Conversation
Signed-off-by: Tyler Weaver <tyler.weaver@kuka.ai>
tylerjw
marked this pull request as ready for review
September 25, 2026 11:44
tylerjw
marked this pull request as draft
September 26, 2026 14:28
Author
|
@YuanYuYuan I noticed my other PR failed so I converted both of these to drafts. At your ROSCON talk I realized we had a similar internal project and that it would be better if we just used yours and contributed fixes where we saw gaps. I have a handful of small things to submit and these are the first two. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve explicit service reply errors instead of dropping them and reporting a generic failure. Distinguish a completed query with no server reply from a timeout, while keeping the first reply as the operation result.