Repository navigation
fix(config): set connect/timeout_ms and connect/exit_on_failure - #357
Merged
Merged
Conversation
Both keys were unset, so a peer session used the Zenoh crate's own connect defaults instead of the values rmw_zenoh_cpp documents in DEFAULT_RMW_ZENOH_SESSION_CONFIG.json5. With no router reachable, the crate default's behavior (retry duration, whether it blocks session start) was never checked against rmw_zenoh_cpp's own: a failed peer connect does not stop or block the session, only a client's does.
The block comment restated investigation detail already covered by each override's own reason field, and stood out against every other entry in this list, which carries no leading comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connect/timeout_msandconnect/exit_on_failurehad no value in the session config. Each one fell back to the Zenoh crate's own default instead of the valuermw_zenoh_cppsets inDEFAULT_RMW_ZENOH_SESSION_CONFIG.json5. This sets both to match.Key Changes
connect/timeout_ms: { router: -1, peer: -1, client: 0 }to the session-specific config overrides.connect/exit_on_failure: { router: false, peer: false, client: true }to the same list.rmw_zenoh_cppconfig onrolling: both values still match exactly.What fails without this
Without this change,
connect/timeout_msandconnect/exit_on_failuredo not match rmw_zenoh_cpp's documented values:timeout_msandexit_on_failure. No test in this crate starts a peer session with no router reachable, so the misalignment never turned a test red — it is a silent config mismatch, not a behavior any existing assertion checks.Breaking Changes
None.