Prevent K2 warning from showing for KSP users - #98
Conversation
| override fun applyToCompilation( | ||
| kotlinCompilation: KotlinCompilation<*>, | ||
| ): Provider<List<SubpluginOption>> { | ||
| kotlinCompilation.compilerOptions.options.let { |
There was a problem hiding this comment.
We should just not do anything here if KSP is being used? I thought that was already the case but seems I misremembered. Is there any reason for the compiler plugin to be configured here?
There was a problem hiding this comment.
Given the state of the library I was trying to keep it small but happy to remove all of this if that's what you'd prefer. AFAIK there's no reason for any of this to stick around. 👍
There was a problem hiding this comment.
let's just have it return early if it's only in KSP mode here, nothing toooo invasive
369b65d to
e7698e3
Compare
e7698e3 to
92950d7
Compare
|
Is this ready for review? Noticed it's still in draft but not sure if you're waiting for me |
|
Sorry still working on this! I got pulled into some other work but will be coming back to this this week. It passes CI here but trying to test in our main repo led to some weird failures so I'm debugging that now. Once this is ready for review I'll move it out of draft and let you know 👍 Thank you for maintaining this project, I promise we're working on migrating to Metro sometime this year 😅 |
72d46c4 to
fe5e006
Compare
fe5e006 to
d8e9d83
Compare
WhosNickDoglio
changed the title
|
Any guidance we need to include in a changelog for this? |
No I don't think so, no changes necessary on the user's end, just the warning going away. 👍 |
2 participants
This PR was AI assisted
The main changes we're updating
isApplicableto return false when KSP was enabled, there was some stuff inapplyToCompilationthat needed to be moved to theapplyfunction as they also applicable for when KSP was enabled.