add disallowing start fn as a config option#2
Open
pwang200 wants to merge 1 commit into
Open
Conversation
pwang200
force-pushed
the
1.0.9_disallow_start
branch
from
48e7a0f to
6c58d8b
Compare
sappenin
reviewed
Jul 10, 2026
| WASMI_CONFIG_PROP(void, ignore_custom_sections, bool) | ||
|
|
||
| /** | ||
| * \brief Whether or not Wasm modules that declare a `start` function are allowed. |
Collaborator
There was a problem hiding this comment.
What's the motivation behind this config flag? Maybe something like this:
Wasm's start function executes automatically when a module is instantiated, before any explicit entry
point is called. This PR closes a potential execution gap by letting the embedder reject any module that
declares a start function outright, rather than allowing it to run code the instant it's loaded.
- If that's accurate, can you update the PR description?
- Is this something that should be proposed in the upstream project?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.