Skip to content

style: Unify style for all Doxygen comments#7776

Open
mathbunnyru wants to merge 16 commits into
XRPLF:developfrom
mathbunnyru:doxygen_style_comments
Open

style: Unify style for all Doxygen comments#7776
mathbunnyru wants to merge 16 commits into
XRPLF:developfrom
mathbunnyru:doxygen_style_comments

Conversation

@mathbunnyru

@mathbunnyru mathbunnyru commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Brings documentation comments into a single, consistent house style. This is a
formatting-only change — no code and no comment wording was altered (verified:
every diff hunk is comment-only, and comment text is preserved verbatim aside
from the tag conversions below).

  • One block style. Converted /// comment blocks and /*! (Qt-style)
    blocks to /** … */, so all Doxygen comments use a single form.
  • Canonical block layout. /** and the closing */ each sit alone on
    their own line; every content line is prefixed with *; bare-indented
    continuation lines (the old "aligned text" style) now carry the * prefix.
  • Briefs and openers. Moved same-line briefs/descriptions
    (/** @brief …, /** text …) off the opener line, and expanded single-line
    /** text */ comments to multi-line blocks.
  • Command style. Converted backslash-style Doxygen commands (\brief,
    \param, …) to the @-form used everywhere else.
  • Prose labels. Replaced prose Returns: / Throws: function-doc labels
    with @return / @throws (the house convention).
  • Indentation cleanup. Flattened spurious leading indentation on comment
    bodies while preserving the relative indentation of embedded @code samples,
    lists, and hanging @param continuations.
  • Scope markers stay compact. Bare section/group markers (@{, @},
    @cond [label], @endcond) are kept as single-line /** … */.
  • Code generation. Updated the protocol codegen Mako templates to emit the
    new style and regenerated protocol_autogen, so generated headers stay
    consistent with the templates.

Left intentionally untouched: ///< / /**< "member-after" comments,
all-slash divider lines, plain non-Doxygen /* … */ comments, and the C++
standardese requirement blocks (Effects: / Preconditions: / nested
Throws:) in hash_append.h and Env.h.

This doesn't change the actual content of comments, doesn't add new annotations and etc..
Only unifies style of most (hopefully, almost all) existing comments which are treated as doxygen commetns.

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mathbunnyru mathbunnyru requested review from bthomee and godexsoft July 9, 2026 18:46
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.6%. Comparing base (8306ac7) to head (8049aa4).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #7776   +/-   ##
=======================================
  Coverage     82.6%   82.6%           
=======================================
  Files         1036    1036           
  Lines        79870   79870           
  Branches      8949    8949           
=======================================
+ Hits         65959   65960    +1     
+ Misses       13902   13901    -1     
  Partials         9       9           
Files with missing lines Coverage Δ
include/xrpl/basics/Buffer.h 100.0% <ø> (ø)
include/xrpl/basics/CompressionAlgorithms.h 0.0% <ø> (ø)
include/xrpl/basics/CountedObject.h 100.0% <ø> (ø)
include/xrpl/basics/DecayingSample.h 88.2% <ø> (ø)
include/xrpl/basics/IntrusivePointer.h 91.7% <ø> (ø)
include/xrpl/basics/IntrusiveRefCounts.h 92.6% <ø> (ø)
include/xrpl/basics/LocalValue.h 100.0% <ø> (ø)
include/xrpl/basics/Log.h 71.4% <ø> (ø)
include/xrpl/basics/MathUtilities.h 0.0% <ø> (ø)
include/xrpl/basics/Number.h 100.0% <ø> (ø)
... and 240 more

... and 206 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@godexsoft godexsoft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much to review - checked by random sampling. In any case this is better than before

@github-actions

Copy link
Copy Markdown

This PR has conflicts, please resolve them in order for the PR to be reviewed.

@github-actions

Copy link
Copy Markdown

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants