Repository navigation
Check cases only for new users, not updates. New tests. - #4749
Open
adamsilverstein wants to merge 6 commits into
Open
adamsilverstein wants to merge 6 commits into
adamsilverstein wants to merge 6 commits into
Conversation
The check reverted in r55584 ran on every save, so updating a user whose username matches their own email, or who already collided with another user, failed. Usernames can only be set on insert, and emails are now compared against existing usernames only when they are new or changing, excluding the user being saved. Existing collisions are left alone, so no previously valid update starts failing. The same email-vs-username check is mirrored in register_new_user(), edit_user(), the REST users update endpoint and the profile email change confirmation, so users see a form error instead of a generic failure. Imports skip the checks, matching the existing email uniqueness check. Claude-Session: https://claude.ai/code/session_01XXGeBhJbUuzyPyZhFKKM5T
Data providers spell out which saves must be blocked and which must keep working, including the cases behind the r55584 revert: a user whose username is their own email, and users whose existing data already collides with another account. Collisions are seeded directly in the database to mirror sites that predate the check. Replaces the earlier single test, which covered only one update case. Claude-Session: https://claude.ai/code/session_01XXGeBhJbUuzyPyZhFKKM5T
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/57394
Testing Instructions
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.