Feeds: Store the resolved MIME type for enclosures - #13984
benitoalba wants to merge 1 commit into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
do_enclose()resolves each URL's MIME type in$type, but saves$mimefrom the extension lookup loop. A URL without an extension can raise an undefined-variable warning, an unknown extension can save an unrelated MIME type, and a later URL can inherit the previous URL's type.Save
$typeso enclosure metadata uses the type that was already checked. The seven new test cases cover those failures, audio and video headers, query-only URLs, extension precedence, and rejection of non-media content. Regenerating the PHPStan baseline removes the obsolete undefined-variable entry.This restores the variable used before r20435. @murshed also included this fix in #12721, which closed when an unrelated Trac ticket was resolved. This PR focuses on enclosures and adds regression coverage.
Trac ticket: https://core.trac.wordpress.org/ticket/65817
Testing
Tested in Core's Docker environment on PHP 8.3.33 and PHPUnit 9.6.37.
./vendor/bin/phpunit tests/phpunit/tests/functions/doEnclose.php: 35 tests, 36 assertions, passed../vendor/bin/phpunit --group functions,feed: 1,330 tests, 2,930 assertions, no failures or errors. The run reported 27 PHPUnit deprecation warnings about error expectations in unchanged tests.Use of AI Tools
AI assistance: Yes
Tool(s): OpenAI Codex
Used for: Issue research, implementation, regression tests, local validation, and this description.
This pull request is for code review only. Please keep other discussion in the Trac ticket. Do not merge this pull request.