Skip to content

Feeds: Store the resolved MIME type for enclosures - #13984

Open
benitoalba wants to merge 1 commit into
WordPress:trunkfrom
benitoalba:benitoalba/65817-enclosure-mime-type
Open

benitoalba wants to merge 1 commit into
WordPress:trunkfrom
benitoalba:benitoalba/65817-enclosure-mime-type

Conversation

@benitoalba

Copy link
Copy Markdown

do_enclose() resolves each URL's MIME type in $type, but saves $mime from the extension lookup loop. A URL without an extension can raise an undefined-variable warning, an unknown extension can save an unrelated MIME type, and a later URL can inherit the previous URL's type.

Save $type so enclosure metadata uses the type that was already checked. The seven new test cases cover those failures, audio and video headers, query-only URLs, extension precedence, and rejection of non-media content. Regenerating the PHPStan baseline removes the obsolete undefined-variable entry.

This restores the variable used before r20435. @murshed also included this fix in #12721, which closed when an unrelated Trac ticket was resolved. This PR focuses on enclosures and adds regression coverage.

Trac ticket: https://core.trac.wordpress.org/ticket/65817

Testing

Tested in Core's Docker environment on PHP 8.3.33 and PHPUnit 9.6.37.

  • Before the fix, the seven new cases produced three undefined-variable errors and two MIME-type assertion failures.
  • ./vendor/bin/phpunit tests/phpunit/tests/functions/doEnclose.php: 35 tests, 36 assertions, passed.
  • ./vendor/bin/phpunit --group functions,feed: 1,330 tests, 2,930 assertions, no failures or errors. The run reported 27 PHPUnit deprecation warnings about error expectations in unchanged tests.
  • Full PHPStan analysis after regenerating the baseline and clearing its cache: passed.
  • WordPress PHPCS: no errors; the test file is clean. The source file has one unchanged SQL warning at line 1858.
  • PHPCompatibility checks on both PHP files: passed.

Use of AI Tools

AI assistance: Yes
Tool(s): OpenAI Codex
Used for: Issue research, implementation, regression tests, local validation, and this description.


This pull request is for code review only. Please keep other discussion in the Trac ticket. Do not merge this pull request.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@benitoalba
benitoalba marked this pull request as ready for review October 4, 2026 18:36
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props benitoalba.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant