Media: Remove redundant array_values call on IPTC keywords in wp_read_image_metadata - #13978
huzaifaalmesbah wants to merge 1 commit into
Conversation
…_image_metadata. In [34374] when IPTC keywords parsing was added, array_values() was called on $iptc['2#025']. In PHP, iptcparse() returns IPTC tags as sequential zero-indexed arrays, so calling array_values() has no effect and surfaces an arrayValues.list PHPStan error. This was the sole occurrence, so the change empties and retires tests/phpstan/baselines/arrayValues.list.neon. See #65817.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
Resolves the
arrayValues.listPHPStan error insrc/wp-admin/includes/image.php.Background & Archaeology
In [34374] (#33772) when IPTC keywords parsing was added to
wp_read_image_metadata(),array_values()was called on$iptc['2#025']. In PHP,iptcparse()returns tag arrays as zero-indexed sequential lists, so callingarray_values()on this list has no effect and surfaces anarrayValues.listerror in PHPStan.Changes
array_values( $iptc['2#025'] )with$iptc['2#025'].composer phpstan:baselines -- --identifier=arrayValues.list. Because this was the sole occurrence across WordPress core,tests/phpstan/baselines/arrayValues.list.neonwas emptied and retired, andphpstan.neon.distupdated.Trac ticket: https://core.trac.wordpress.org/ticket/65817
Use of AI Tools
AI assistance: Yes
Tool(s): Google Antigravity
Model(s): Gemini 3.8 Flash
Used for: Code archaeology, PHPStan baseline regeneration, and PR description formatting.