Skip to content

Fix: Toolbar: live-preview of unsaved display name change is not accurate #13881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hbhalodia wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Fix: Toolbar: live-preview of unsaved display name change is not accurate #13881

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bc7e75
Fix live preview of the toolbar account menu when changing the displa…
hbhalodia Oct 1, 2026
25182c9
Merge branch 'trunk' into fix/issue-66222
hbhalodia Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions src/js/_enqueues/admin/user-profile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
var updateLock = false,
isSubmitting = false,
__ = wp.i18n.__,
sprintf = wp.i18n.sprintf,
clipboard = new ClipboardJS( '.application-password-display .copy-button' ),
$pass1Row,
$pass1,
Expand Down Expand Up @@ -496,7 +497,10 @@
var $colorpicker, $stylesheet, user_id, current_user_id,
select = $( '#display_name' ),
current_name = select.val(),
greeting = $( '#wp-admin-bar-my-account' ).find( '.display-name' );
greeting = $( '#wp-admin-bar-my-account > .ab-item .display-name' ),
userInfo = $( '#wp-admin-bar-user-info' ),
infoName = userInfo.find( '.display-name' ).not( '.edit-profile' ),
userActions = $( '#wp-admin-bar-user-actions' );

$( '#pass1' ).val( '' ).on( 'input' + ' pwupdate', check_pass_strength );
$('#pass-strength-result').show();
Expand Down Expand Up @@ -540,16 +544,31 @@
});

/**
* Replaces "Howdy, *" in the admin toolbar whenever the display name dropdown is updated for one's own profile.
* Updates the account menu in the admin toolbar whenever the display name dropdown is updated for one's own profile.
*/
select.on( 'change', function() {
if ( user_id !== current_user_id ) {
return;
}

var display_name = this.value.trim() || current_name;
var display_name = this.value.trim() || current_name,
user_login = $( '#user_login' ).val() || '',
username = userInfo.find( '.username' );

greeting.text( display_name );
infoName.text( display_name );

/* translators: %s: Current user's display name. */
userActions.attr( 'aria-label', sprintf( __( 'Howdy, %s' ), display_name ) );

// Mirror the server-side logic: only show the username when it differs from the display name.
if ( display_name === user_login ) {
username.remove();
} else if ( username.length ) {
username.text( user_login );
} else if ( infoName.length ) {
$( '<span />', { 'class': 'username', 'text': user_login } ).insertAfter( infoName );
}
} );
}

Expand Down
Loading