Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
In practical terms, I'm unable to see any actual consequences of this difference. The logic seems reasonable to me, but I can't see any actual difference in behavior. Would appreciate a 2nd opinion here, @westonruter or @adamsilverstein |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
westonruter
left a comment
There was a problem hiding this comment.
This looks correct. Previously, if there was more than one popover opened at once, then the timeout ID in openTimeout would get clobbered by the second opened popover, meaning the first wouldn't ever automatically close.
Adds a PR applying @murshed's diff to move the declaration of the
openTimeoutvariable.Trac ticket: https://core.trac.wordpress.org/ticket/65674