Skip to content

Apply wp-tooltip.diff as PR - #13449

Closed
joedolson wants to merge 1 commit into
WordPress:trunkfrom
joedolson:move-tooltip-delay-timer
Closed

joedolson wants to merge 1 commit into
WordPress:trunkfrom
joedolson:move-tooltip-delay-timer

Conversation

@joedolson

Copy link
Copy Markdown
Contributor

Adds a PR applying @murshed's diff to move the declaration of the openTimeout variable.

Trac ticket: https://core.trac.wordpress.org/ticket/65674

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joedolson.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@joedolson

Copy link
Copy Markdown
Contributor Author

In practical terms, I'm unable to see any actual consequences of this difference. The logic seems reasonable to me, but I can't see any actual difference in behavior.

Would appreciate a 2nd opinion here, @westonruter or @adamsilverstein

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@westonruter westonruter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct. Previously, if there was more than one popover opened at once, then the timeout ID in openTimeout would get clobbered by the second opened popover, meaning the first wouldn't ever automatically close.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 63549
GitHub commit: 447d765

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants