Icons: Rebalance a few, add other new icons.

[jasmussen]

What?

Related to WordPress/wordpress-develop#12270.

Rebalances Plugins and Comment icons to better fit in context of the admin menu, and adds new icons: paintbrush, multimedia, reaction (for @adamsilverstein), fullscreen-exit (from a discussion with @simison about a counterpart to the fullscreen icon), and a new justify-space-evenly.

Do we need all the new icons? Worth a discussion, notably justify-space-evenly depends on whether we want to add that or not. But overall, much of this exists to support the work to replace dashicons in the admin, and is based on the subsequent feedback:

Testing Instructions

npm run storybook:dev
Search for Icons library

Use of AI Tools

Opus 5 for a bit of normalisation.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: fushar <fushar@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

🤖 PR meta 🤖

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric	75f5e5e	trunk	% Change
timeToFirstByte	55.75 ms +5.56% -1.79%	55.9 ms +4.38% -2.59%	-0.27%
largestContentfulPaint	96 ms +2.08% -6.25%	94 ms +2.13% -6.38%	2.13%
lcpMinusTtfb	36.4 ms +14.7% -8.65%	34.3 ms +21.28% -5.98%	6.12%
wpBeforeTemplate	27.94 ms +8.84% -1.86%	28.05 ms +5.81% -1.11%	-0.39%
wpTemplate	24.13 ms +1.86% -3.65%	23.61 ms +4.28% -2.84%	2.2%
wpTotal	52.1 ms +5.51% -1.71%	52.32 ms +4.2% -2.87%	-0.42%
wpMemoryUsage	7.61 MB +0% -0%	7.57 MB +0% -0%	0.51%
wpDbQueries	17 +0% -0%	17 +0% -0%	0%

front-end-classic-theme

Metric	75f5e5e	trunk	% Change
timeToFirstByte	47 ms +5.53% -1.49%	46.75 ms +6.63% -1.6%	0.53%
largestContentfulPaint	100 ms +4% -0%	100 ms +4% -0%	0%
lcpMinusTtfb	54.05 ms +2.04% -1.67%	53.35 ms +1.41% -2.16%	1.31%
wpBeforeTemplate	25.85 ms +8.28% -1.24%	26.07 ms +7.06% -0.88%	-0.84%
wpTemplate	17.67 ms +3% -1.81%	17.45 ms +1.83% -0.57%	1.26%
wpTotal	44.15 ms +5.75% -1.59%	43.8 ms +6.67% -1.23%	0.8%
wpMemoryUsage	6.22 MB +0% -0%	6.19 MB +0% -0%	0.57%
wpDbQueries	14 +0% -0%	14 +0% -0%	0%

media-processing

Metric	75f5e5e	trunk	% Change
mediaProcessingJpeg	393.54 ms +1.49% -0.29%	395.32 ms +0.5% -0.77%	-0.45%
mediaProcessingAvif	6028.17 ms +0.1% -0.12%	6037.75 ms +0.31% -0.17%	-0.16%
mediaProcessingJpegToAvif	4169.96 ms +0.3% -0.09%	4174.56 ms +0.27% -0.33%	-0.11%

media-upload

Metric	75f5e5e	trunk	% Change
jpegUploadProcessing	1424.48 ms +35.77% -0.71%	1408.74 ms +1.14% -0.13%	1.12%
pngUploadProcessing	169.12 ms +38.26% -1.79%	175.14 ms +3.74% -5.22%	-3.44%
largeJpegUploadProcessing	1404.64 ms +1.56% -0.38%	1397.32 ms +0.95% -0.48%	0.52%
multipleImageUploadProcessing	1554.61 ms +1.45% -0.43%	1570.01 ms +10.06% -1.2%	-0.98%

post-editor

Metric	75f5e5e	trunk	% Change
serverResponse	428.71 ms +3.24% -4.18%	433.02 ms +2.58% -7.74%	-1%
firstPaint	236.03 ms +18.9% -15.34%	223.82 ms +20.34% -11.29%	5.46%
domContentLoaded	1120.76 ms +2.17% -2.73%	1113.73 ms +2.19% -2.72%	0.63%
loaded	1122.06 ms +2.18% -2.72%	1115.06 ms +2.21% -2.71%	0.63%
firstContentfulPaint	459.06 ms +2.91% -6.16%	450.33 ms +7.16% -2.69%	1.94%
firstBlock	3258.28 ms +0.64% -0.32%	3233.83 ms +0.87% -0.95%	0.76%
type	22.13 ms +3.71% -3.62%	21.59 ms +1.95% -2.69%	2.5%
typeWithoutInspector	19.81 ms +2.52% -5.2%	21.35 ms +14.1% -4.26%	-7.21%
typeWithTopToolbar	26.1 ms +4.67% -4.48%	27.21 ms +6.8% -5.55%	-4.08%
typeContainer	9.41 ms +7.44% -8.5%	8.89 ms +12.37% -0.79%	5.85%
focus	74.42 ms +6.81% -9.65%	80.74 ms +1.08% -3.06%	-7.83%
firstFocus	206.44 ms +0% -0%	194.99 ms +0% -0%	5.87%
selectAll	497.89 ms +1.06% -3.91%	489.96 ms +10.92% -2.7%	1.62%
listViewOpen	59.46 ms +11.74% -10.98%	62.86 ms +5.35% -1.1%	-5.41%
inserterOpen	24.88 ms +10.97% -6.15%	24.65 ms +5.48% -6.09%	0.93%
inserterHover	3.59 ms +20.33% -15.32%	3.58 ms +7.54% -8.1%	0.28%
inserterSearch	7.99 ms +12.64% -3.63%	7.56 ms +13.23% -4.23%	5.69%
loadPatterns	667.72 ms +1.99% -3.29%	690.73 ms +0.38% -8.83%	-3.33%
wpTotal	417.45 ms +3.34% -4.29%	422.16 ms +2.33% -8.02%	-1.12%
wpMemoryUsage	13.14 MB +0% -0%	13.11 MB +0% -0%	0.28%
wpDbQueries	54 +0% -1.85%	54 +0% -0%	0%

site-editor

Metric	75f5e5e	trunk	% Change
serverResponse	484.15 ms +3.52% -3.83%	492.78 ms +2.69% -8.4%	-1.75%
firstPaint	261.31 ms +18.85% -11.86%	259.46 ms +4.96% -9.01%	0.71%
domContentLoaded	1123.38 ms +1.16% -1.68%	1109.54 ms +0.48% -0.76%	1.25%
loaded	1124.48 ms +1.16% -1.69%	1110.63 ms +0.48% -0.75%	1.25%
firstContentfulPaint	436.1 ms +4.41% -2.04%	432.81 ms +2.06% -2.22%	0.76%
firstBlock	4058.82 ms +1.16% -0.27%	4058.52 ms +0.81% -0.36%	0.01%
type	19.37 ms +7.38% -5.32%	19.11 ms +5.97% -7.17%	1.36%
navigate	121.87 ms +10.09% -8.51%	112.04 ms +2.28% -5.5%	8.77%
loadPatterns	1235.98 ms +5.39% -4.1%	1220.98 ms +17.57% -4.1%	1.23%
loadPages	1044.57 ms +2.55% -0.85%	1043.1 ms +1.63% -0.81%	0.14%
wpTotal	474.49 ms +3.68% -3.81%	482.82 ms +2.9% -8.45%	-1.73%
wpMemoryUsage	12.11 MB +0% -0%	12.09 MB +0% -0%	0.13%
wpDbQueries	43 +2.33% -0%	43.5 +1.15% -1.15%	-1.15%

_{700d209 Run}

[jameskoster]

Do we definitely need multimedia, or should we update media?

[jasmussen]

Do we need it? Not clear, and yes there is room to update media which I personally don't think is different enough from Image to be meaningful. Happy to do so.

But just to be exhaustive, it exists based on the feedback here, WordPress/wordpress-develop#12270 (comment), so I would like to stick mostly to the recommendations outlined there. What do you think?

[fushar]

I don't know if we want to have a large or small, curated set of icons 😄 but: I think I agree that we should just update the existing media icon ( ). Currently, it looks too similar to an existing image icon ( ); they are not really distinguishable.

Similarly, for paintbrush, maybe we should just update existing brush instead? I checked the Gutenberg codebase; it does not seem we really already use brush for our UI.

I might be a bit biased, but doing the above means we do nothing to update our Core PR 😄 WordPress/wordpress-develop#12270

[jameskoster]

In this case I'd vote for updating the existing icons.

[jasmussen]

Alright, I've gone ahead and updated/replaced the icons, instead of adding new ones. I will surface that this updates the icon here:

Which is fine, in my opinion, since the label refers to media library, and the new icon is de-facto what's been used for the media library for a while.

[t-hamano]

I think we can go ahead with this PR. The justify-space-evenry icon will also be useful for #71129.

[t-hamano]

Can you move each icon to its correct position in alphabetical order?

[jasmussen]

Should be done now. A few other bits were out of order too.

[t-hamano]

LGTM!

[fushar]

Thanks for this, let's go!

[jasmussen]

Noting that I will likely head to lunch before the tests pass. I'll certainly merge if I come back and see a green button, but also wanted to note that you are all free to do it as well in my absence, if things move.

[fushar]

Yep let's merge this because this will conflict with Aki's #83261 🙏

[t-hamano]

Resolved conflicts.