Icons: Move the public property from icons to collections

[t-hamano]

Note

This pull request is a prerequisite for #83261.

What?

See #83261 (comment).

Moves the icon registry's public property from individual icons to collections.

Why?

WordPress/wordpress-develop#12270 uses the icon registry for the admin bar and sidebar. #82634 introduced an icon-level public option so those icons could remain available to PHP without appearing in the REST API or Icon block.

However, consumers unregistering the core collection to customize the Icon block would also remove the dashboard icons. #83261 proposes a separate core-admin collection to address this. With that separation, visibility can be configured for the entire collection instead of each icon.

How?

• Adds public to wp_register_icon_collection(), defaulting to true. Non-public collections and their icons are excluded from REST responses, while their icons remain available through wp_get_icon().
• Removes the icon-level registry option and reverts the tri-state manifest behavior introduced in Icons: Allow icons to ship to WordPress Core without exposing them in the Icon block  #82634, which has not shipped in a Gutenberg plugin release. The manifest's public flag continues to control which icons ship to Core.

Testing Instructions

1. Temporarily add 'public' => false to the core collection's registration arguments in gutenberg_register_default_icon_collections() in lib/icons.php.

--- a/lib/icons.php
+++ b/lib/icons.php
@@ -15,6 +15,7 @@
 		array(
 			'label'       => __( 'WordPress', 'gutenberg' ),
 			'description' => __( 'Core icon collection.', 'gutenberg' ),
+			'public'      => false,
 		)
 	);
 }

2. Reload the post editor and run the following in the browser console. Confirm that the collections omit core and the icons omit every core/ icon:

await wp.apiFetch( { path: '/wp/v2/icon-collections' } );
await wp.apiFetch( { path: '/wp/v2/icons' } );

3. Confirm that requesting the non-public collection's icons rejects with a 404 (rest_icon_collection_not_found):

await wp.apiFetch( { path: '/wp/v2/icons/core' } );

4. Confirm that wp_get_icon( 'core/plus' ) still returns SVG markup in PHP.
5. Remove the temporary public argument and reload. Confirm that the core collection and its icons are exposed again.

Use of AI Tools

Codex was used to inspect the changes, run validation, and prepare this PR description.

[github-actions]

🤖 PR meta 🤖

📦 Bundle size

Size Change: 0 B

Total Size: 8.21 MB

_{64cfc13 Run}

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric	bc80502	trunk	% Change
timeToFirstByte	57.7 ms +11.27% -3.21%	57.75 ms +9.52% -3.98%	-0.09%
largestContentfulPaint	100 ms +2% -4%	96 ms +6.25% -4.17%	4.17%
lcpMinusTtfb	38.2 ms +15.97% -7.59%	36.2 ms +5.66% -7.6%	5.52%
wpBeforeTemplate	28.3 ms +19.43% -1.24%	28.71 ms +5.96% -2.96%	-1.43%
wpTemplate	24.97 ms +2.92% -4.25%	24.58 ms +6.39% -3.86%	1.59%
wpTotal	53.99 ms +10.56% -3.3%	54.13 ms +9% -4.23%	-0.26%
wpMemoryUsage	7.59 MB +0% -0%	7.56 MB +0% -0%	0.38%
wpDbQueries	17 +0% -0%	17 +0% -0%	0%

front-end-classic-theme

Metric	bc80502	trunk	% Change
timeToFirstByte	43.4 ms +11.41% -2.19%	47.7 ms +7.13% -1.26%	-9.01%
largestContentfulPaint	92 ms +6.52% -0%	104 ms +0% -3.85%	-11.54%
lcpMinusTtfb	49.25 ms +2.54% -4.97%	53.35 ms +4.31% -1.41%	-7.69%
wpBeforeTemplate	26.31 ms +15.58% -1.82%	26.37 ms +3.91% -0.34%	-0.23%
wpTemplate	13.95 ms +3.08% -1.94%	18.44 ms +2.49% -3.8%	-24.35%
wpTotal	40.64 ms +10.8% -2.46%	44.72 ms +7.13% -1.45%	-9.12%
wpMemoryUsage	6.07 MB +0% -0%	6.17 MB +0% -0%	-1.74%
wpDbQueries	10 +0% -0%	14 +0% -0%	-28.57%

media-processing

Metric	bc80502	trunk	% Change
mediaProcessingJpeg	397.59 ms +2.11% -0.45%	395.4 ms +1.79% -0.73%	0.55%
mediaProcessingAvif	6043.9 ms +0.32% -0.29%	6061.06 ms +0.23% -0.11%	-0.28%
mediaProcessingJpegToAvif	4161.68 ms +0.06% -0.31%	4181.82 ms +0.2% -0.11%	-0.48%

media-upload

Metric	bc80502	trunk	% Change
jpegUploadProcessing	1690.02 ms +15.84% -15.39%	1425.78 ms +0.41% -1.17%	18.53%
pngUploadProcessing	220.55 ms +5.81% -6.53%	218.69 ms +3.34% -6.28%	0.85%
largeJpegUploadProcessing	1406.45 ms +0.69% -0.47%	1421.13 ms +0.64% -0.35%	-1.03%
multipleImageUploadProcessing	1583.8 ms +0.66% -1.22%	1627.43 ms +27.55% -1.93%	-2.68%

post-editor

Metric	bc80502	trunk	% Change
serverResponse	517.2 ms +1.03% -3.78%	492.91 ms +7.78% -4.22%	4.93%
firstPaint	222.79 ms +17.49% -14.14%	239.56 ms +9.97% -3.48%	-7%
domContentLoaded	1098.86 ms +0.86% -0.96%	1101.12 ms +0.57% -1.38%	-0.21%
loaded	1100.3 ms +0.88% -0.98%	1102.4 ms +0.58% -1.36%	-0.19%
firstContentfulPaint	450.44 ms +4.83% -4.44%	448.43 ms +2.21% -1.57%	0.45%
firstBlock	3268.02 ms +0.47% -0.48%	3274.25 ms +0.96% -0.96%	-0.19%
type	20.31 ms +4.28% -5.66%	19.94 ms +5.52% -2.26%	1.86%
typeWithoutInspector	18.4 ms +2.55% -3.26%	21.32 ms +1.31% -8.3%	-13.7%
typeWithTopToolbar	25.56 ms +3.21% -2.19%	23.89 ms +8.08% -2.85%	6.99%
typeContainer	9.1 ms +5.16% -1.54%	9.49 ms +5.8% -3.9%	-4.11%
focus	72.77 ms +8.44% -6.13%	75.22 ms +10.66% -10%	-3.26%
firstFocus	231.35 ms +0% -0%	207.31 ms +0% -0%	11.6%
selectAll	531.23 ms +1.47% -9.48%	510.46 ms +1.64% -6.02%	4.07%
listViewOpen	76.83 ms +5.13% -5.06%	73.53 ms +5.25% -5.3%	4.49%
inserterOpen	23.74 ms +12.38% -5.52%	23.26 ms +13.37% -10.23%	2.06%
inserterHover	3.44 ms +7.56% -7.85%	3.25 ms +9.85% -4.62%	5.85%
inserterSearch	7.83 ms +16.48% -8.94%	7.7 ms +6.88% -2.21%	1.69%
loadPatterns	633.67 ms +3.55% -1.65%	646.75 ms +3.98% -3.59%	-2.02%
wpTotal	506.64 ms +1.15% -3.79%	482.98 ms +7.72% -4.23%	4.9%
wpMemoryUsage	13.13 MB +0% -0%	13.10 MB +0% -0%	0.24%
wpDbQueries	54 +0% -1.85%	54 +0% -1.85%	0%

site-editor

Metric	bc80502	trunk	% Change
serverResponse	370.77 ms +8.01% -1.5%	403.88 ms +2.62% -5.13%	-8.2%
firstPaint	221.83 ms +39.44% -10.09%	226.6 ms +33.7% -12.08%	-2.11%
domContentLoaded	1102.03 ms +1.24% -0.83%	1099.66 ms +2.84% -1.14%	0.22%
loaded	1103.22 ms +1.23% -0.83%	1100.85 ms +2.84% -1.13%	0.22%
firstContentfulPaint	448.27 ms +1.55% -3.94%	446.81 ms +4.55% -4.04%	0.33%
firstBlock	3907.53 ms +0.94% -0.49%	3983.86 ms +0.95% -0.66%	-1.92%
type	19.12 ms +10.51% -6.12%	20.13 ms +6.26% -2.68%	-5.02%
navigate	107.04 ms +4.48% -8.43%	119.35 ms +9.78% -8.55%	-10.31%
loadPatterns	1242.39 ms +8.85% -11.39%	1251.76 ms +20.5% -3.22%	-0.75%
loadPages	1096.32 ms +1.77% -2.26%	1134.28 ms +1.45% -2.27%	-3.35%
wpTotal	359.87 ms +8.26% -1.55%	392.87 ms +2.81% -5.12%	-8.4%
wpMemoryUsage	12.10 MB +0% -0%	12.06 MB +0% -0%	0.36%
wpDbQueries	43 +2.33% -0%	43 +2.33% -0%	0%

_{64cfc13 Run}

[t-hamano]

This is for backward compatibility. I add a dedicated collection registry for Gutenberg to ensure that the latest registry supporting public properties is always used across all WordPress versions supported by the Gutenberg plugin, regardless of the state of the core collection registry.

[t-hamano]

Similar to the collection registry, this is also intended to override the core REST controller.

[Copilot]

Copilot review overview

Review effort: Balanced
Findings: None

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: fushar <fushar@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[fushar]

I haven't reviewed the code in details, but: maybe it's much easier to test if we also add the core-admin/ registration in this PR? Or did you intend to do it as a separate PR?

I think it will also easier to review, as then manifest.json changes will have public: false changed to admin: true 🤔

[t-hamano]

Personally, I wanted to split the PR—that is, the core commits—into two, because each PR represents a separate enhancement.

[t-hamano]

At the very least, this PR needs to be included in Gutenberg 24.1; otherwise, the icon-level public option that this PR aims to remove will be exposed.

[fushar]

Yes. Reviewing it right now!

[fushar]

Checked the changes, and followed the test instructions. Looks good and works great. Thanks for this 🙏 👍

[fushar]

Hmm maybe we can just remove the following old entry instead? It's still in the Unreleased section.

manifest.json: The public property is now a tri-state.

[t-hamano]

Admittedly, this is confusing, but I believe that changelog entries should basically be append-only and past entries should not be removed. As long as README.md reflects the latest specifications, it shouldn't be an issue.

[t-hamano]

I will merge this PR to include it in Gutenberg 24.1. If any issues arise, I'll follow up as needed. Even if it misses tomorrow's 24.1 RC1 release, we can backport it to RC2 if it requires an urgent fix.

[fushar]

Thank you! I assume you will also update your other PR to add the icons to core-admin/ private collection? I'll review and test it as well when done. I think, ideally it should also ship with 24.1, then we sync to wordpress-develop trunk so that the dashicon PR can be finally properly testable. (It's a long journey!)

[t-hamano]

I assume you will also update your other PR to add the icons to core-admin/ private collection?

Yes. Since there is a time lag between the release of the Gutenberg plugin and its actual synchronization with WordPress Core, I plan to include the necessary PRs in the plugin release as soon as possible.