You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Refreshed with Claude's help to point at #83786 as the main PR, now that #79864 is closed.
What?
Render floating Notes as part of the editor canvas surface - overlaying space reserved inside the canvas - rather than inside an "invisible" complementary-area sidebar.
This is a broader, design-intent framing of the problem behind #73917. The fix is now #83786, which moves floating notes into a canvas margin owned by VisualEditor; it is stacked on #83768, which adds the show/hide notes options. Earlier attempts (#77484, #79864) are closed. Where #73917 reports one symptom (notices don't span the full width), this issue captures the underlying goal: notes should live in the margin of the canvas, like margin notes on an essay, matching the original designs.
Why?
Today, floating notes render inside a transparentPluginSidebar. Because the editor layout treats any active sidebar as a layout-occupying column, this indirection produces a cluster of problems and diverges from the intended design:
Misplaced scrollbar. The canvas scrollbar lands in the middle of the viewport, at the edge of the invisible sidebar, instead of at the editor's edge.
Can't coexist with the inspector. Only one complementary area can be active, so floating notes and the Settings sidebar can't be open at the same time.
A sidebar we don't want. The notes already show at the right of the content whether or not the "All notes" sidebar is open, so routing them through a hidden sidebar is an implementation artifact, not a design choice.
The intended treatment - discussed in #77484 and earlier in #66377 (comment) - is to treat notes as part of the canvas surface: reserve an area inside the canvas (e.g. margin on the html element, as in zoom-out mode) and position the note UI over it as an overlay, horizontally aligned with the blocks they annotate. This keeps the canvas (and its background and scrollbar) at full editor width and lets notes coexist with the inspector.
Goal
Notes appear "in the margin" of the canvas, as an overlay on reserved in-canvas space, so that:
The canvas - and its scrollbar - stay at the full editor content width.
Follow-ups discussed in #77484, tracked separately: the tablet "bubble" mode, mobile per-note markers from the Figma designs, and in-canvas notices (#79010).
What?
Render floating Notes as part of the editor canvas surface - overlaying space reserved inside the canvas - rather than inside an "invisible" complementary-area sidebar.
This is a broader, design-intent framing of the problem behind #73917. The fix is now #83786, which moves floating notes into a canvas margin owned by
VisualEditor; it is stacked on #83768, which adds the show/hide notes options. Earlier attempts (#77484, #79864) are closed. Where #73917 reports one symptom (notices don't span the full width), this issue captures the underlying goal: notes should live in the margin of the canvas, like margin notes on an essay, matching the original designs.Why?
Today, floating notes render inside a transparent
PluginSidebar. Because the editor layout treats any active sidebar as a layout-occupying column, this indirection produces a cluster of problems and diverges from the intended design:The intended treatment - discussed in #77484 and earlier in #66377 (comment) - is to treat notes as part of the canvas surface: reserve an area inside the canvas (e.g. margin on the
htmlelement, as in zoom-out mode) and position the note UI over it as an overlay, horizontally aligned with the blocks they annotate. This keeps the canvas (and its background and scrollbar) at full editor width and lets notes coexist with the inspector.Goal
Notes appear "in the margin" of the canvas, as an overlay on reserved in-canvas space, so that:
alignfull) never renders under the notes area.FLOATING_NOTES_SIDEBARand friends) is retired.Related
Out of scope
Follow-ups discussed in #77484, tracked separately: the tablet "bubble" mode, mobile per-note markers from the Figma designs, and in-canvas notices (#79010).