Skip to content

fix(api): lock repository during template downloads - #22502

Merged
nijel merged 1 commit into
mainfrom
api-dowload
Nov 1, 2026
Merged

nijel merged 1 commit into
mainfrom
api-dowload

Conversation

@nijel

@nijel nijel commented Nov 1, 2026

Copy link
Copy Markdown
Member

Hold the repository lock from path validation through archive reads to prevent symlink races with concurrent VCS updates. Snapshot regular files before streaming and refresh lock leases during archive creation.

Add regression coverage for lock ownership, linked repositories, download permissions, failure cleanup, and lock contention.

@nijel nijel added this to the 2026.11 milestone Nov 1, 2026
@nijel nijel self-assigned this Nov 1, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T11:51:33.251062Z c704951 New commits
🔒 Security Review ✅ Completed 2026-11-01T07:53:26.354558Z 87e4dfd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87e4dfd623

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread weblate/utils/views.py Resolved
Hold the repository lock from path validation through archive reads to prevent symlink races with concurrent VCS updates. Snapshot regular files before streaming and refresh lock leases during archive creation.

Add regression coverage for lock ownership, linked repositories, download permissions, failure cleanup, and lock contention.
@nijel
nijel enabled auto-merge (rebase) November 1, 2026 11:50
@nijel
nijel merged commit 2bdbf8c into main Nov 1, 2026
44 of 45 checks passed
@nijel
nijel deleted the api-dowload branch November 1, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant