Skip to content

feat(auth): preserve built-in role customizations across upgrades - #22498

Open
nijel wants to merge 2 commits into
mainfrom
feat/editable-builtin-roles
Open

nijel wants to merge 2 commits into
mainfrom
feat/editable-builtin-roles

Conversation

@nijel

@nijel nijel commented Oct 31, 2026

Copy link
Copy Markdown
Member

Allow administrators to edit and reset built-in role permissions while protecting role identity and deletion. Freeze upstream defaults in generated data migrations and merge permission changes without overwriting local customizations.

@nijel nijel added this to the 2026.11 milestone Oct 31, 2026
@nijel nijel self-assigned this Oct 31, 2026

@accesslint accesslint Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 1 issue across 1 rule.

Reviewed by AccessLint, which checks every pull request for accessibility issues.

<p>{% translate "Reset these built-in roles to the current default permissions? This discards their customizations." %}</p>
<form method="post">
{% csrf_token %}
<ul>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WCAG 1.3.1: <ul> contains direct text content. Wrap in <li> or <style>.

<ul> and <ol> must only contain <li>, <script>, <template>, or <style> as direct children.

Details

Screen readers announce list structure ('list with 5 items') based on proper markup. Placing non-<li> elements directly inside <ul> or <ol> breaks this structure. Wrap content in <li> elements, or if you need wrapper divs for styling, apply styles to <li> elements directly and remove the wrapper (e.g., change <ul>``<div>item</div>``</ul> to <ul>``<li>item</li>``</ul>).

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T18:46:13.465181Z d662a5b New commits
🔒 Security Review ✅ Completed 2026-10-31T18:07:01.321156Z fb3cc02 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@nijel
nijel enabled auto-merge (rebase) October 31, 2026 18:08
Allow administrators to edit and reset built-in role permissions while protecting role identity and deletion. Freeze upstream defaults in generated data migrations and merge permission changes without overwriting local customizations.
@nijel
nijel force-pushed the feat/editable-builtin-roles branch from 8056292 to d662a5b Compare October 31, 2026 18:44

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant