Repository navigation
feat(auth): preserve built-in role customizations across upgrades - #22498
Conversation
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
There was a problem hiding this comment.
Found 1 issue across 1 rule.
Reviewed by AccessLint, which checks every pull request for accessibility issues.
| <p>{% translate "Reset these built-in roles to the current default permissions? This discards their customizations." %}</p> | ||
| <form method="post"> | ||
| {% csrf_token %} | ||
| <ul> |
There was a problem hiding this comment.
WCAG 1.3.1: <ul> contains direct text content. Wrap in <li> or <style>.
<ul> and <ol> must only contain <li>, <script>, <template>, or <style> as direct children.
Details
Screen readers announce list structure ('list with 5 items') based on proper markup. Placing non-<li> elements directly inside <ul> or <ol> breaks this structure. Wrap content in <li> elements, or if you need wrapper divs for styling, apply styles to <li> elements directly and remove the wrapper (e.g., change <ul>``<div>item</div>``</ul> to <ul>``<li>item</li>``</ul>).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Allow administrators to edit and reset built-in role permissions while protecting role identity and deletion. Freeze upstream defaults in generated data migrations and merge permission changes without overwriting local customizations.
8056292 to
d662a5b
Compare
Replace unreleased installation-wide visibility settings with editable global role permissions while preserving scoped contributor discovery and administrative access. Add frozen role and team migrations, regression coverage, and a privacy configuration guide covering profiles and private VCS identities. Refs #22370, #22498, #18054
Replace unreleased installation-wide visibility settings with editable global role permissions while preserving scoped contributor discovery and administrative access. Add frozen role and team migrations, regression coverage, and a privacy configuration guide covering profiles and private VCS identities. Refs #22370, #22498, #18054
Replace unreleased installation-wide visibility settings with editable global role permissions while preserving scoped contributor discovery and administrative access. Add frozen role and team migrations, regression coverage, and a privacy configuration guide covering profiles and private VCS identities. Refs #22370, #22498, #18054
Replace unreleased installation-wide visibility settings with editable global role permissions while preserving scoped contributor discovery and administrative access. Add frozen role and team migrations, regression coverage, and a privacy configuration guide covering profiles and private VCS identities. Refs #22370, #22498, #18054
Allow administrators to edit and reset built-in role permissions while protecting role identity and deletion. Freeze upstream defaults in generated data migrations and merge permission changes without overwriting local customizations.