Repository navigation
feat(subagents): manage MCP instruction loading - #318
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (22)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughDevSpace adds ChangesSubagent instruction delivery
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change adds configurable subagent instruction delivery and synchronizes the bundled workflow into the managed DevSpace skill path. The supported configuration and workspace behaviors are covered, with no identified merge-blocking risk. Sequence Diagram(s)sequenceDiagram
participant open_workspace
participant loadSkills
participant ManagedSkill
open_workspace->>loadSkills: load skills for the workspace
loadSkills->>ManagedSkill: synchronize and reload subagents SKILL.md
ManagedSkill-->>loadSkills: return managed skill
loadSkills-->>open_workspace: return skills and workspace context
open_workspace->>open_workspace: embed instructions when mode is preload
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 16 files. (6 skipped: 6 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR introduces configurable loading of the managed Subagents workflow for MCP workspaces.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, security, or repository-rule violations identified. Managed-skill synchronization, configuration compatibility, onboarding preservation, and both instruction-loading modes remain internally consistent and are covered by focused tests.
|
| Filename | Overview |
|---|---|
| src/skills.ts | Synchronizes the packaged Subagents skill into the managed directory and ensures that managed copy is authoritative. |
| src/server.ts | Selects between advertising the Subagents skill and embedding its workflow in initial workspace instructions. |
| src/local-agent-config.ts | Adds validated on-demand and preload instruction modes with a backward-compatible default. |
| src/onboarding.ts | Preserves the configured instruction-loading mode when onboarding updates provider selections. |
| schema/v1/devspace.schema.json | Publishes the new instruction mode and default in the versioned configuration schema. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Load workspace skills] --> B{Subagents enabled?}
B -- No --> C[Remove reserved subagents skill]
B -- Yes --> D[Refresh managed SKILL.md]
D --> E[Load managed subagents skill]
E --> F{Instruction mode}
F -- on-demand --> G[Advertise skill in open_workspace]
F -- preload --> H[Hide skill advertisement]
H --> I[Embed workflow in initial workspace instructions]
Reviews (1): Last reviewed commit: "docs(subagents): clarify managed instruc..." | Re-trigger Greptile
…ding feat(subagents): manage MCP instruction loading
ChatGPT MCP workspaces currently fall back to the packaged
subagentsskill, which exposes package-manager-specific paths and leaves instruction loading fixed. This change synchronizes the bundled skill into the reserved~/.devspace/skills/subagents/SKILL.mdpath when MCP workspace skills are loaded and refreshes that managed copy from the installed DevSpace package.It also adds
subagents.instructionswithon-demandas the default andpreloadas the alternative. On-demand advertises the skill for the model to read only when delegation is useful; preload includes the workflow in the initialopen_workspaceinstructions instead. Coding Agent installation through the Skills CLI remains separate and unchanged.Summary by CodeRabbit
New Features
subagents.instructionsconfiguration withon-demandandpreloadmodes.Documentation