fix: Removed trailing slash for conversations URIs - #626
Merged
Conversation
fix: Removed trailing slashes on conversation URIs Bumped to 9.12.0 for release
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
=========================================
Coverage 99.05% 99.05%
Complexity 3643 3643
=========================================
Files 548 548
Lines 8051 8052 +1
Branches 444 445 +1
=========================================
+ Hits 7975 7976 +1
Misses 56 56
Partials 20 20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Removes trailing slashes from Vonage Conversations API request URIs (to match current API gateway routing behavior) and bumps the SDK version for release.
Changes:
- Strips a trailing
/from Conversations API endpoint URLs at request-build time. - Updates Conversations client endpoint tests to expect non-trailing-slash URIs.
- Bumps version references from
9.11.0to9.12.0in code and documentation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/main/java/com/vonage/client/conversations/ConversationsClient.java |
Normalizes Conversations endpoint URLs by removing a trailing slash before sending requests. |
src/test/java/com/vonage/client/conversations/ConversationsClientTest.java |
Updates expected endpoint URIs to match the new non-trailing-slash behavior. |
src/main/java/com/vonage/client/HttpWrapper.java |
Updates the SDK client version string to 9.12.0. |
pom.xml |
Bumps project version to 9.12.0. |
README.md |
Updates dependency snippets to 9.12.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Removed trailing slashes on conversation URIs
Bumped to 9.12.0 for release
Describe your changes here
Contribution Checklist