Skip to content

fix: Removed trailing slash for conversations URIs - #626

Merged
dragonmantank merged 1 commit into
mainfrom
fix/conversations-trailing-slash-routing
Jul 25, 2026
Merged

fix: Removed trailing slash for conversations URIs#626
dragonmantank merged 1 commit into
mainfrom
fix/conversations-trailing-slash-routing

Conversation

@dragonmantank

Copy link
Copy Markdown
Member

fix: Removed trailing slashes on conversation URIs

Bumped to 9.12.0 for release

Describe your changes here

Contribution Checklist

fix: Removed trailing slashes on conversation URIs

Bumped to 9.12.0 for release
@codecov-commenter

codecov-commenter commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (a9c514d) to head (a8828c4).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #626   +/-   ##
=========================================
  Coverage     99.05%   99.05%           
  Complexity     3643     3643           
=========================================
  Files           548      548           
  Lines          8051     8052    +1     
  Branches        444      445    +1     
=========================================
+ Hits           7975     7976    +1     
  Misses           56       56           
  Partials         20       20           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes trailing slashes from Vonage Conversations API request URIs (to match current API gateway routing behavior) and bumps the SDK version for release.

Changes:

  • Strips a trailing / from Conversations API endpoint URLs at request-build time.
  • Updates Conversations client endpoint tests to expect non-trailing-slash URIs.
  • Bumps version references from 9.11.0 to 9.12.0 in code and documentation.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/main/java/com/vonage/client/conversations/ConversationsClient.java Normalizes Conversations endpoint URLs by removing a trailing slash before sending requests.
src/test/java/com/vonage/client/conversations/ConversationsClientTest.java Updates expected endpoint URIs to match the new non-trailing-slash behavior.
src/main/java/com/vonage/client/HttpWrapper.java Updates the SDK client version string to 9.12.0.
pom.xml Bumps project version to 9.12.0.
README.md Updates dependency snippets to 9.12.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dragonmantank
dragonmantank merged commit 206526c into main Jul 25, 2026
17 checks passed
@dragonmantank
dragonmantank deleted the fix/conversations-trailing-slash-routing branch July 25, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants