Add public Tokenize() API to the VQL lexer - #139
Closed
predictiple wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Velociraptor LSP server's semantic-highlighting handler (textDocument/semanticTokens) needs lexical information that the AST-based APIs deliberately hide: comment tokens and the raw surface of the query, down to token classification. Until now the VQL lexer (
vqlLexer) was unexported, so there was no supported way to get tokens.This adds no new grammar or parsing logic - it is a thin, purely additive wrapper over the existing
lexer.StatefulDefinitionthat already feeds the participle parsers. Because it uses the same lexer the real parser consumes, the tokens can never drift out of sync with what Velociraptor actually accepts (unlike a shadow grammar such as tree-sitter).Also includes three unit tests covering token stream contents, position monotonicity, and the fact that comments survive tokenization even though parse APIs elide them.