fix: use agent workspace in ArtifactPanel when no explicit workspace is set - #1210
Open
ditingdapeng wants to merge 1 commit into
Open
ditingdapeng wants to merge 1 commit into
ditingdapeng wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77e48e01be
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…is set When the effective workspace falls back to the default (~/.openclaw/workspace) but the current agent has its own dedicated workspace, the ArtifactPanel file browser now prefers the agent's workspace. This ensures users see their agent-specific files (AGENTS.md, TOOLS.md with custom tool configs, etc.) rather than the generic defaults. The fix only affects the ArtifactPanel props; ChatInput workspace selector and sidebar session grouping logic remain unchanged.
ditingdapeng
force-pushed
the
fix/artifact-panel-agent-workspace-resolution
branch
from
July 31, 2026 12:04
77e48e0 to
f3a001a
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
When chatting with a non-default agent that has its own dedicated workspace (e.g.,
~/.openclaw/workspace-laoa), the ArtifactPanel workspace browser incorrectly displays files from the default workspace (~/.openclaw/workspace) instead of the agent's workspace.This happens because
resolveEffectiveWorkspace()falls back to the default workspace path when no session or global workspace is explicitly set. The non-empty default value (~/.openclaw/workspace) is passed toWorkspaceBrowserBodyasworkspacePath, which prevents theagent?.workspacefallback from ever triggering.Fixes #1209
Why This Change Was Made
The fix adds a computed
artifactPanelWorkspacethat checks: when the effective workspace source is"default"(i.e., no explicit user/session choice) AND the current agent has a non-default workspace, prefer the agent's workspace for the file browser panel.This only affects the ArtifactPanel props. The ChatInput workspace selector, sidebar session grouping, and all other workspace-dependent logic remain unchanged.
User Impact
Evidence
pnpm run typecheck:node— passed (0 errors)oxlint src/pages/Chat/index.tsx— 0 errors, 0 warningsuseMemohooks + prop update)