Skip to content

fix: use agent workspace in ArtifactPanel when no explicit workspace is set - #1210

Open
ditingdapeng wants to merge 1 commit into
ValueCell-ai:mainfrom
ditingdapeng:fix/artifact-panel-agent-workspace-resolution
Open

ditingdapeng wants to merge 1 commit into
ValueCell-ai:mainfrom
ditingdapeng:fix/artifact-panel-agent-workspace-resolution

Conversation

@ditingdapeng

Copy link
Copy Markdown

What Problem This Solves

When chatting with a non-default agent that has its own dedicated workspace (e.g., ~/.openclaw/workspace-laoa), the ArtifactPanel workspace browser incorrectly displays files from the default workspace (~/.openclaw/workspace) instead of the agent's workspace.

This happens because resolveEffectiveWorkspace() falls back to the default workspace path when no session or global workspace is explicitly set. The non-empty default value (~/.openclaw/workspace) is passed to WorkspaceBrowserBody as workspacePath, which prevents the agent?.workspace fallback from ever triggering.

Fixes #1209

Why This Change Was Made

The fix adds a computed artifactPanelWorkspace that checks: when the effective workspace source is "default" (i.e., no explicit user/session choice) AND the current agent has a non-default workspace, prefer the agent's workspace for the file browser panel.

This only affects the ArtifactPanel props. The ChatInput workspace selector, sidebar session grouping, and all other workspace-dependent logic remain unchanged.

User Impact

  • Before: Users with custom agents see generic default workspace files in the browser panel, missing their agent-specific TOOLS.md, AGENTS.md configurations
  • After: The workspace browser correctly shows the current agent's dedicated workspace and its custom files

Evidence

  • pnpm run typecheck:node — passed (0 errors)
  • oxlint src/pages/Chat/index.tsx — 0 errors, 0 warnings
  • Change is minimal: 1 file, +23 lines (two useMemo hooks + prop update)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77e48e01be

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/Chat/index.tsx Outdated
Comment thread src/pages/Chat/index.tsx
…is set

When the effective workspace falls back to the default (~/.openclaw/workspace)
but the current agent has its own dedicated workspace, the ArtifactPanel file
browser now prefers the agent's workspace. This ensures users see their
agent-specific files (AGENTS.md, TOOLS.md with custom tool configs, etc.)
rather than the generic defaults.

The fix only affects the ArtifactPanel props; ChatInput workspace selector
and sidebar session grouping logic remain unchanged.
@ditingdapeng
ditingdapeng force-pushed the fix/artifact-panel-agent-workspace-resolution branch from 77e48e0 to f3a001a Compare July 31, 2026 12:04
@ditingdapeng

Copy link
Copy Markdown
Author

@su8su @ashione @z0gSh1u Gentle ping — this PR has been open for 2 days with no reviewer assigned. Could someone take a look when available? The automated review comments have already been addressed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Workspace browser shows default workspace files instead of agent-specific workspace

1 participant