Fix for Minimap texture copy warning - #474
Closed
MidnightsFX wants to merge 1 commit into
Closed
Conversation
Member
|
The underlying reason for the error seems to be because Valheim changed the TextureFormat of the fog texture. Copying the texture over via a |
Contributor
Author
|
Closing this to replace with just texture format changes as requested. #476 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix texture mismatch when writing multiple layers, avoid format incompatibilities.
This fixes the discrepancy created when copying textures currently (CPU vs GPU do not match).
Which is caused by using the minimap overlay system. Currently creating an overlay causes this warning each time the texture is written.
While technically harmless unless another Copy(), or GetPixels() is called, if either is invoked it will use stale data from the CPU cache (which is outdated).
To fix this and address the formatting issues which cause it, this performs just a GPU -> GPU copy.
If you would like to test or reproduce, StarLevelSystems includes an overlay by default which runs into this issue.