Skip to content

fix: error message for maximum FAP grade #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zacharyjhankin merged 5 commits into from
Sep 16, 2026
Merged

fix: error message for maximum FAP grade #1786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1367623
fix: maximum greade
zacharyjhankin Sep 9, 2026
607e7e1
change language to minimum
zacharyjhankin Sep 11, 2026
f2479ca
Merge branch 'develop' into fix-max-grade2
zacharyjhankin Sep 11, 2026
004a57e
Merge branch 'develop' into fix-max-grade2
zacharyjhankin Sep 11, 2026
ffe583d
Merge branch 'develop' into fix-max-grade2
zacharyjhankin Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/e2e/cypress/e2e/FAPs.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4148,7 +4148,7 @@ context('Fap meeting components tests', () => {

cy.get('[data-cy="save-and-continue-button"]').focus().click();

cy.contains('Lowest grade is 1');
cy.contains('Minimum grade is 1');

cy.get('#grade-proposal').click().clear().clear().type('1.001');

Expand Down
4 changes: 2 additions & 2 deletions .../questionary/questionaryComponents/FapReviewBasis/createFapReviewBasisValidationSchema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ export const createFapReviewBasisValidationSchema: QuestionaryComponentDefinitio
const schema = Yup.object().shape({
comment: commentSchema,
grade: Yup.string()
.test('min', `Lowest grade is ${config.minGrade}`, (val) => {
.test('min', `Minimum grade is ${config.minGrade}`, (val) => {
if (val === undefined) return false;

const number = parseFloat(val);

return isNaN(number) ? true : number >= config.minGrade;
})
.test('max', `Lowest grade is ${config.maxGrade}`, (val) => {
.test('max', `Maximum grade is ${config.maxGrade}`, (val) => {
Comment thread
zacharyjhankin marked this conversation as resolved.
if (val === undefined) return false;

const number = parseFloat(val);
Expand Down
Loading