Repository navigation
CURA-13349 Fix support on vertical/top faces - #2390
Merged
Merged
Conversation
CURA-13349 When creating the mesh modifier to force the overhang, it does offset around the painted surface. As a result, the support would try to support the enlarged part outside the model. Now we force it to stay inside the model, resulting in the purely vertical or top-facing areas to be ignored
Copilot started reviewing on behalf of
Erwan MATHIEU (wawanbreton)
September 29, 2026 07:28
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused geometry change correctly addresses the described support-placement issue without introducing unresolved concerns.
Review effort: Balanced
Findings: None
What changed in this PR
Clips forced-overhang regions to model outlines, preventing support generation outside vertical or top-facing surfaces.
Changes:
- Intersects forced-overhang polygons with the current layer’s model outline.
| File | Description |
|---|---|
src/support.cpp |
Constrains forced overhangs to model geometry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
The previous fix (intersect the forced support with the outlines) was a step in the right direction, but it didn't completely solve the problem; this fix is a bit more agressive, in that it actually (indirectly) detects wether or not something is vertical. This is because since we now substract the (original, not extended by a value derived from the support angle) outlines below, which should only net us areas where there's _any_ excuse at all for support, and thus exclude completely vertical or 'top' surfaces. part of CURA-13349
Contributor
Author
|
I cannot officially |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating the mesh modifier to force the overhang, it does offset around the painted surface. As a result, the support would try to support the enlarged part outside the model. Now we force it to stay inside the model, resulting in the purely vertical or top-facing areas to be erased.
CURA-13349