fix(ui5-toolbar): fix padding variable swap, item spacing, and Toolba…#13593
Open
PetyaMarkovaBogdanova wants to merge 2 commits into
Open
fix(ui5-toolbar): fix padding variable swap, item spacing, and Toolba…#13593PetyaMarkovaBogdanova wants to merge 2 commits into
PetyaMarkovaBogdanova wants to merge 2 commits into
Conversation
…rItem display Agent-Logs-Url: https://github.com/UI5/webcomponents/sessions/4fddc2f7-637b-475b-aa77-cb4a38583e71 Co-authored-by: PetyaMarkovaBogdanova <15124079+PetyaMarkovaBogdanova@users.noreply.github.com>
|
|
Collaborator
|
🚀 Deployed on https://pr-13593--ui5-webcomponents-preview.netlify.app |
kgogov
requested changes
May 28, 2026
Contributor
kgogov
left a comment
kgogov
left a comment
There was a problem hiding this comment.
Hello @PetyaMarkovaBogdanova,
It looks like there is a failing test: "Should focus on the last interactive element outside the overflow popover when the overflow button disappears."
The issue is reproducible locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three CSS bugs in
ui5-toolbaridentified via visual spec analysis against the AI test review.Changes
Toolbar.css— Fix swapped variable names inpaddingshorthand.padding: 0 right 0 leftwas referencing--_ui5-toolbar-padding-leftfor the right slot and vice versa:Toolbar-parameters.css— Bump--_ui5-toolbar-item-margin-rightfrom0.25rem→0.5remto match the visual spec.ToolbarItem.css— Removedisplay: inline-blockfrom:host. This was preventing flex-based responsive sizing for slotted content (e.g.ui5-breadcrumbs) because inline-block constrains the host to shrink-to-content width rather than participating correctly in the toolbar's flex layout.