fix(cypress-commands): support Cypress v16 - #8952
Open
Lukas742 wants to merge 4 commits into
Open
Conversation
Updates Cypress everywhere else as well.
Contributor
|
Size Change: -1 B (0%) Total Size: 529 kB 📦 View Changed
ℹ️ View Unchanged
|
The published @ui5/webcomponents-cypress-commands@2.26.0 still declares a peer of cypress@"^12 || ^13 || ^14 || ^15", so bumping the standalone examples/vite-ts and templates/vite-ts to cypress@16 breaks their `npm ci` with ERESOLVE. Revert those two projects to 15.21.1 (and restore allowCypressEnv: false) until a cypress-commands release with a ^16 peer is published. The peer-range fix in packages/cypress-commands/package.json is intentionally kept.
Coverage Report for CI Build 34479404211Coverage remained the same at 85.825%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
The React-18-only 'initial scroll-to' test still used should('not.be.visible')
for cells scrolled out of the table container. Cypress 16's modern visibility
algorithm counts scrolled-out-but-laid-out elements as visible, so those
assertions failed only on the React 18 CI job (the test is skipped on React 19,
where the earlier conversions were validated). Convert the four sites to
should('be.scrolledOutOfView'), matching the rest of the spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Cypress everywhere else as well.