Ensure Top-Level examples/ Directory#1470
Conversation
aaronmondal
left a comment
There was a problem hiding this comment.
Nice!
Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Bazel Dev / macos-13, Bazel Dev / macos-14, Bazel Dev / ubuntu-24.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Coverage, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, NativeLink.com Cloud / Remote Cache / macos-14, NativeLink.com Cloud / Remote Cache / ubuntu-24.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, Web Platform Deployment / macos-14, Web Platform Deployment / ubuntu-24.04, docker-compose-compiles-nativelink (22.04), macos-13, pre-commit-checks, windows-2022 / stable, and 2 discussions need to be resolved
-- commits line 2 at r1:
nit: "Ensure"
local-remote-execution/README.md line 195 at r1 (raw file):
Start the cluster and set up NativeLink in an LRE configuration. For details on this refer to the [Kubernetes example](https://github.com/tracemachina/nativelink/tree/main/deployment-examples/kubernetes):
nit: This one should probably point to https://www.nativelink.com/docs/deployment-examples/kubernetes
local-remote-execution/README.md line 246 at r1 (raw file):
resources: - https://github.com/TraceMachina/nativelink//examples/kubernetes/base
fyi I need to revisit this one as it's outdated. Not much we can do in this pr though.
examples/ Directoryexamples/ Directory
Description
We need to include a top-level examples directory.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is