Added new ways to view plot borders with rainbow effects and also sam… - #8303
Open
xghostxcodex wants to merge 1 commit into
Open
xghostxcodex wants to merge 1 commit into
xghostxcodex wants to merge 1 commit into
Conversation
LlmDl
requested changes
Sep 15, 2026
LlmDl
left a comment
Member
There was a problem hiding this comment.
This pr currently has a lot of unneeded formatting changes made to it.
To get this reviewed properly I will need you to undo the unneeded changes made in formatting:
- Imports moving around,
- Removed comments,
- returns and continues moved off of newlines,
- anything else that was changed but didn't need it.
…e for town borders. and wilderness highlights in red too. so some cool new features and made it so you can add it to the config so it's a owner setting to toggle. enjoy thanks xghostxcodex
xghostxcodex
force-pushed
the
master
branch
from
September 15, 2026 19:22
37a6700 to
a0dc820
Compare
Author
|
hey super sorry, still getting used to intellij formatting things, but I fixed it up to hopefully your formatting desire, please let me know if I can do anything else to enhance it or anything. I appreciate you considering my contribution |
Member
|
Thanks I'll take a look when I can after the 26.3 release for towny is done.
Hopefully we can get the rendering into a unified system that merges the
old with the new, only changing how things get rendered.
…On Tue, Sep 15, 2026, 2:36 PM xghostxcodex ***@***.***> wrote:
*xghostxcodex* left a comment (TownyAdvanced/Towny#8303)
<#8303 (comment)>
hey super sorry, still getting used to intellij formatting things, but I
fixed it up to hopefully your formatting desire, please let me know if I
can do anything else to enhance it or anything. I appreciate you
considering my contribution
—
Reply to this email directly, view it on GitHub
<#8303?email_source=notifications&email_token=AAGWZDAX2S4UCDASEEOF7OD5PGK5FA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNRYGY4TSOJUGA42M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5686999409>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGWZDF6GJF5TMDFYZDFL2T5PGK5FAVCNFSNUABEKJSXA33TNF2G64TZHMZDONJSGQ3DAMB3JFZXG5LFHM2TINJXGA3TQMZQGSQXMAQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Author
|
sounds good man, take your time with the 26.3 release. and yeah a unified rendering system sounds like a clean way to handle it that should probably do the trick I would imagine. appreciate you taking a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e for town borders. and wilderness highlights in red too. so some cool new features and made it so you can add it to the config so it's a owner setting to toggle. enjoy thanks xghostxcodex
Description:
the purpose of this request is to make plot borders pretty! and town borders too of course. oh and the red for the wilderness view, quality of life stuffs. also makes it so you can see border while flying
New Nodes/Commands/ConfigOptions:
no new perm nodes, just maybe configs you toggle/you have to create spots for in your config for to toggle it the original way you had it and this new rainbow box method.
Relevant Towny Issue ticket:
nope; discussed on discord
Attestations
yessir I did, and it works lovely. hope you like it too.
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.
In making this pull request, I declare that I have not used an AI toolset to design or code this pull request, and that I am a human who coded this without any influence from an LLM.