Repository navigation
deps: quick-xml 0.42 - #47
Merged
Merged
Conversation
quick-xml 0.42 hands element and attribute names back as &str, so the Nmap XML importer no longer re-decodes them as UTF-8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #42, whose CI fails to compile: quick-xml 0.42 changed
QNameandAttribute::keyto wrap&strinstead of&[u8]. The Nmap XML importer now takes the names directly instead of running them throughstd::str::from_utf8.Workspace: fmt, clippy, 347 tests green, including the Nmap XML parse and import tests.