Repository navigation
Finish the axum 0.8 migration so main builds again - #38
Merged
Merged
Conversation
…ect-info extractor)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #29 bumped axum to 0.8.9 but the code still targeted 0.7, so
agentsniffno longer compiles on main (Rust security checks and the Docker build are red on 21cb385). Three changes finish the migration:check_handlertookOption<ConnectInfo<SocketAddr>>; axum 0.8 only acceptsOption<T>for extractors that opt in. It now takesResult<ConnectInfo<SocketAddr>, ExtensionRejection>and converts with.ok(), so a router without connect info (the test routers) still works./check/{*rest}and/api/scan/{scan_id}. Under 0.8 the old:/*forms panic at router construction.Verified locally with the locked 0.8.9 dependency set:
cargo test --workspace --lockedhas no failures (gate 38, server 14),cargo fmt --checkand clippy-D warningsclean. PR #37 is blocked on this; its CI runs against the merge ref and hits the same compile error.