Skip to content

fix: initialize generated_keys set in pre_generate_bib_entries #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
douden merged 1 commit into from
Mar 16, 2026
+2 −0
Merged

fix: initialize generated_keys set in pre_generate_bib_entries #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sphinx_metadata_figure/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1441,6 +1441,7 @@ def pre_generate_bib_entries(app, config):
# This avoids the race condition where a parallel reader could access
# the file between a delete and a partial re-write.
new_entries = []
generated_keys = set() # track keys already queued in this scan
for bib_key, options, image_path, caption in figures_with_bib:
# Check if key already exists in user-managed bib files
if bib_key in generated_keys:
Expand All @@ -1463,6 +1464,7 @@ def pre_generate_bib_entries(app, config):
if metadata:
bib_entry = _generate_bib_entry(bib_key, metadata, image_path, caption)
new_entries.append((bib_key, bib_entry))
generated_keys.add(bib_key)

generated_count = 0
if new_entries:
Expand Down